Segmentation fault on exit in Time destructor

[akien-mga]

• boscaeceoil-blue version: YuriSizov/boscaceoil-blue@d578cc4
• gdsion version: 0a3cc4d
• godot version: godotengine/godot@e001bc7
• OS: Fedora 40, compiled with GCC 14

---

When testing boscaceoil-blue with self-compiled gdsion and latest upstream Godot, I get a segfault on exit (just running the project, not doing anything and quitting with the X window button triggers it).

The stacktrace isn't super helpful:

(gdb) bt
#0  0x00007fffdea5df4b in ?? ()
YuriSizov/boscaceoil-blue#1  0x000000000aad035c in Object::~Object (this=0xb276090, __in_chrg=<optimized out>) at ./core/object/object.cpp:2145
#2  0x000000000a528ff1 in Time::~Time (this=0xb276090, __in_chrg=<optimized out>) at ./core/os/time.cpp:450
#3  0x000000000a4d1ca8 in memdelete<Time> (p_class=0xb276090) at ./core/os/memory.h:116
YuriSizov/gdsion#12  0x000000000a484f36 in unregister_core_types () at ./core/register_core_types.cpp:441
#5  0x0000000005b7255c in Main::cleanup (p_force=false) at main/main.cpp:4317
#6  0x0000000005ab37d1 in main (argc=1, argv=0x7fffffffd728) at platform/linuxbsd/godot_linuxbsd.cpp:89

I'm using dev_builds for both Godot and GDSiON but can't seem to get more details from gdb. I'm not sure if it's not able to load debug symbols from the shared library or if it's something else.

Might very well be a Godot or godot-cpp bug, but starting with a downstream report until we can assess where the crash comes from.

---

The stacktrace mentions the Time destructor, and I see it's indeed used by GDSiON:

$ rg Time
src/sion_driver.cpp
449:    int start_time = Time::get_singleton()->get_ticks_msec();
461:    _performance_stats.processing_time_data->value = Time::get_singleton()->get_ticks_msec() - start_time;
501:    int start_time = Time::get_singleton()->get_ticks_msec();
505:    _performance_stats.compiling_time = Time::get_singleton()->get_ticks_msec() - start_time;
523:    int start_time = Time::get_singleton()->get_ticks_msec();
531:    _performance_stats.rendering_time = Time::get_singleton()->get_ticks_msec() - start_time;
815:    _performance_stats.frame_timestamp = Time::get_singleton()->get_ticks_msec();
902:    int start_time = Time::get_singleton()->get_ticks_msec();
907:                    _performance_stats.compiling_time += Time::get_singleton()->get_ticks_msec() - start_time;
913:                    int rendering_time = Time::get_singleton()->get_ticks_msec() - start_time;
920:                            rendering_time = Time::get_singleton()->get_ticks_msec() - start_time;
923:                    _performance_stats.rendering_time += Time::get_singleton()->get_ticks_msec() - start_time;
939:    int t = Time::get_singleton()->get_ticks_msec();

src/sequencer/base/mml_parser.cpp
335:    _parsing_time = Time::get_singleton()->get_ticks_msec();
371:    _start_time = Time::get_singleton()->get_ticks_msec();
556:    _parsing_time = Time::get_singleton()->get_ticks_msec() - _parsing_time;
782:            return _interrupt_interval < (Time::get_singleton()->get_ticks_msec() - _start_time);

Presumably removing this Time::get_singleton() dependency might "solve" the issue. I'll see if I can make a MRP using Time::get_singleton() that crashes similarly so we can move the bug report upstream.

[akien-mga]

Yeah I could reproduce this upstream with:

diff --git a/test/src/example.cpp b/test/src/example.cpp
index 3ec8bca..89e5d12 100644
--- a/test/src/example.cpp
+++ b/test/src/example.cpp
@@ -11,6 +11,7 @@
 #include <godot_cpp/classes/label.hpp>
 #include <godot_cpp/classes/multiplayer_api.hpp>
 #include <godot_cpp/classes/multiplayer_peer.hpp>
+#include <godot_cpp/classes/time.hpp>
 #include <godot_cpp/variant/utility_functions.hpp>
 
 using namespace godot;
@@ -297,6 +298,8 @@ Example::~Example() {
 
 // Methods.
 void Example::simple_func() {
+	int time = Time::get_singleton()->get_ticks_msec();
+	printf("time: %d\n", time);
 	emit_custom_signal("simple_func", 3);
 }
 

I'll open an issue on godot-cpp.
Edit: I see it's already reported on godotengine/godot-cpp#889 and you commented there.

Feel free to close this as an upstream bug, unless you want to work it around downstream to avoid the crash.

[YuriSizov]

Thanks for the report!

Yeah, it's well known at this point, but having an official issue on this here is a good thing. I'll keep it open as a reminder, because indeed I may have to work around it on GDSiON's end using mihe's suggestion. I'll just transfer this to the GDSiON repo, since there is nothing that can be done in Bosca Ceoil's code.

[YuriSizov]

godotengine/godot-cpp#1458 resolves the crash, so a workaround is not necessary. But I can't update to a newer version of godot-cpp just yet because no official build of 4.3 is compatible with it (see PackedVector4Array changes). So will have to wait until beta 1 or 2. Keeping it open in the meantime.