Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish the structured-data-blocks stylesheet #10834

Closed
afercia opened this issue Aug 29, 2018 · 0 comments · Fixed by #11926
Closed

Polish the structured-data-blocks stylesheet #10834

afercia opened this issue Aug 29, 2018 · 0 comments · Fixed by #11926
Labels
component: gutenberg component: gutenblocks

Comments

@afercia
Copy link
Contributor

afercia commented Aug 29, 2018

Follow up to #10814 (comment)

css/src/structured-data-blocks.scss

Many styles in this file are duplicated across the How-to and FAQ components and could be greatly simplified. Also, we should never use named colors e.g. lightgrey.
@IreneStr IreneStr added backlog and removed next labels Sep 14, 2018
@afercia afercia self-assigned this Dec 3, 2018
@afercia afercia mentioned this issue Dec 28, 2018
Merged
@afercia afercia removed their assignment Jan 3, 2019
@IreneStr IreneStr added the queue label Jan 11, 2019
@abotteram abotteram self-assigned this Jan 15, 2019
@abotteram abotteram removed their assignment Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: gutenberg component: gutenblocks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

How-to and FAQ blocks improvements Yoast/wordpress-seo
5 participants
@omarreiss @afercia @moorscode @abotteram @IreneStr