Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order mismatch between Velocity and NoteOff message when writing #8

Closed
Natooz opened this issue Dec 21, 2023 · 3 comments
Closed

Order mismatch between Velocity and NoteOff message when writing #8

Natooz opened this issue Dec 21, 2023 · 3 comments

Comments

@Natooz
Copy link
Contributor

Natooz commented Dec 21, 2023

Following #6, we found an issue with the order of the velocity and NoteOff messages when parsing / writing notes having the same onset time and pitch values.

This is likely to be a FIFO / LIFO issue, either one of these principle should be applied for both parsing and writing in order to keep the data integrity.

@Yikai-Liao
Copy link
Owner

We have updated minimidi and symusic. Well, currently it is not an efficient solution, but I think it could pass the test.
However, the test in actions got some problems, running test scripts in 3rdparty/pybind11 and failed.

@Natooz
Copy link
Contributor Author

Natooz commented Dec 21, 2023

Great!
I'll try to fix the test script issue

@Natooz
Copy link
Contributor Author

Natooz commented Dec 21, 2023

Unfortunatly I have two bad news:

  1. renaming the symusic directory kinda broke the local installation (pip install .), I had to rename it symusic to install the latest updates. Now the good news is that after this, the tests ran normally locally without having to rename the directory. I don't know yet why, I'm not a pro of python building/packaging, I don't know what we should do here;
  2. the test results are still the same, the velocity mismatch doesn't seem to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants