You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following #6, we found an issue with the order of the velocity and NoteOff messages when parsing / writing notes having the same onset time and pitch values.
This is likely to be a FIFO / LIFO issue, either one of these principle should be applied for both parsing and writing in order to keep the data integrity.
The text was updated successfully, but these errors were encountered:
We have updated minimidi and symusic. Well, currently it is not an efficient solution, but I think it could pass the test.
However, the test in actions got some problems, running test scripts in 3rdparty/pybind11 and failed.
renaming the symusic directory kinda broke the local installation (pip install .), I had to rename it symusic to install the latest updates. Now the good news is that after this, the tests ran normally locally without having to rename the directory. I don't know yet why, I'm not a pro of python building/packaging, I don't know what we should do here;
the test results are still the same, the velocity mismatch doesn't seem to be fixed.
Following #6, we found an issue with the order of the velocity and NoteOff messages when parsing / writing notes having the same onset time and pitch values.
This is likely to be a FIFO / LIFO issue, either one of these principle should be applied for both parsing and writing in order to keep the data integrity.
The text was updated successfully, but these errors were encountered: