Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support for old buffers #935

Closed
totaam opened this issue Aug 2, 2015 · 16 comments
Closed

remove support for old buffers #935

totaam opened this issue Aug 2, 2015 · 16 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Aug 2, 2015

Issue migrated from trac ticket # 935

component: core | priority: critical | resolution: fixed

2015-08-02 16:46:47: antoine created the issue


Follow up from #465, see also #1073.
This will mean dropping compatibility with Python versions older than 2.7, which means that the release before it would probably have to be LTS.

@totaam
Copy link
Collaborator Author

totaam commented Aug 2, 2015

2015-08-02 16:53:44: antoine uploaded file memoryview-buffer-wrapper.patch (35.5 KiB)

switch to a wrapper class for memalign memory

@totaam
Copy link
Collaborator Author

totaam commented Aug 2, 2015

2015-08-02 16:55:45: antoine changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Aug 2, 2015

2015-08-02 16:55:45: antoine commented


The patch above removes lots of ugly code, can help us avoid making copies in some cases and speeds up argb and cyxor by a factor of 2.

And whilst we're at it, we could probably drop support for Python3 versions older than 3.3 so we can assume PyMemoryView_FromMemory is present.

@totaam
Copy link
Collaborator Author

totaam commented Nov 13, 2015

2015-11-13 13:26:35: antoine commented


Let's make 0.17 and LTS, do this after.

@totaam
Copy link
Collaborator Author

totaam commented Jul 12, 2016

2016-07-12 17:51:51: antoine commented


Milestone renamed

@totaam
Copy link
Collaborator Author

totaam commented Aug 21, 2016

2016-08-21 10:55:50: antoine commented


Milestone renamed

@totaam
Copy link
Collaborator Author

totaam commented Dec 16, 2016

2016-12-16 19:09:41: antoine commented


r14514 removes support for old style buffers

@totaam
Copy link
Collaborator Author

totaam commented Dec 16, 2016

2016-12-16 22:16:57: antoine changed status from assigned to new

@totaam
Copy link
Collaborator Author

totaam commented Dec 16, 2016

2016-12-16 22:16:57: antoine changed owner from antoine to smo

@totaam
Copy link
Collaborator Author

totaam commented Dec 16, 2016

2016-12-16 22:16:57: antoine commented


The memoryview-buffer-wrapper patch has been merged in r14557.

Potential problems with this:

  • performance? (should be at least as good as before)
  • memory leaks, memory corruption, etc (fun!)

@smo: please run the automated tests and compare with v1.0 so we can make sure we don't have regressions anywhere.

@totaam
Copy link
Collaborator Author

totaam commented Dec 30, 2016

2016-12-30 07:09:23: antoine changed priority from major to critical

@totaam
Copy link
Collaborator Author

totaam commented Dec 30, 2016

2016-12-30 07:09:23: antoine edited the issue description

@totaam
Copy link
Collaborator Author

totaam commented Jan 29, 2017

2017-01-29 13:58:10: antoine commented


More related changes: r14519 (assume memoryview type is available), r14885: zerocopy in network layer!

@totaam
Copy link
Collaborator Author

totaam commented Mar 28, 2017

2017-03-28 01:26:26: smo changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Mar 28, 2017

2017-03-28 01:26:26: smo set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Mar 28, 2017

2017-03-28 01:26:26: smo commented


These have been in for some time and many automated tests ran with no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant