Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opencl improvements, ie: no float #437

Closed
totaam opened this issue Oct 7, 2013 · 5 comments
Closed

opencl improvements, ie: no float #437

totaam opened this issue Oct 7, 2013 · 5 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Oct 7, 2013

Issue migrated from trac ticket # 437

component: core | priority: minor | resolution: fixed

2013-10-07 09:44:39: totaam created the issue


After testing on both GPU and CPU, it seems that using ints instead of floats can give a 50% performance boost for CPU - and interestingly, absolutely zero for GPU.
It might be worth doing anyway sometime, patch attached.
There are probably other performance improvements we could make.

@totaam
Copy link
Collaborator Author

totaam commented Oct 8, 2013

2013-10-08 16:16:31: totaam uploaded file csc_opencl-nofloat-v2.patch (23.5 KiB)

implements all calculations using integers

@totaam
Copy link
Collaborator Author

totaam commented Oct 8, 2013

2013-10-08 16:32:26: totaam changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Oct 8, 2013

2013-10-08 16:32:26: totaam changed resolution from ** to fixed

@totaam
Copy link
Collaborator Author

totaam commented Oct 8, 2013

2013-10-08 16:32:26: totaam commented


done in r4425 - only tested RGB to YUV (not the other way around).

Gains are between 0% (Intel SDK with AMD CPU) to 50% (AMD SDK with AMD GPU at 420P) - the CSC will need updating...

@totaam totaam closed this as completed Oct 8, 2013
@totaam
Copy link
Collaborator Author

totaam commented May 19, 2014

2014-05-19 13:39:53: totaam commented


(setting correct milestone the work was completed in)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant