pixbuf_new_from_data or cairo take un-premultiplied rgb data

[totaam]

Issue migrated from trac ticket # 416

component: client | priority: major | resolution: fixed

2013-08-12 11:26:28: totaam created the issue

---

r4151 does this, but it's slow and ugly.

Do this in-place properly, or at least return a string we can use directly.

[totaam]

2013-12-03 07:24:53: totaam uploaded file mmap-argb-in-place.patch (1.0 KiB)

remove unnecessary conversions with mmap codepath only

[totaam]

2013-12-03 07:26:10: totaam changed status from new to assigned

[totaam]

2013-12-03 07:26:10: totaam changed owner from antoine to totaam

[totaam]

2013-12-03 07:26:10: totaam commented

---

The problem is that:

• we can get a string as data (from all encoders that can output with alpha: rgb, png, webp) or a class 'xpra.net.mmap_pipe.c_char_Array_409600' with mmap. A string cannot be used as writeable buffer but the c_char_Array can.
• the data we pass to pixbuf_new_from_data() must be string or read-only buffer, not bytearray

The patch above skips the conversions for the mmap codepath, but we need something that also addresses the double-copy from the standard codepath.

[totaam]

2013-12-03 08:51:30: totaam changed status from assigned to closed

[totaam]

2013-12-03 08:51:30: totaam changed resolution from ** to fixed

[totaam]

2013-12-03 08:51:30: totaam commented

---

Done in r4843 (see changeset for details)

• mmap: zero copy

• string buffers: one copy with numpy (cannot be avoided)
• without numpy installed: two copies as before

More buffer work in #465