use X11 keyboard API instead of execing new processes #371

totaam · 2013-07-06T09:26:12Z

Issue migrated from trac ticket # 371

component: keyboard | priority: blocker | resolution: fixed

2013-07-06 09:26:12: antoine created the issue

xkbcommon docs

[/wiki/Keyboard Keyboard wiki]

xkb docs

totaam · 2013-07-16T06:43:55Z

2013-07-16 06:43:55: antoine changed status from new to assigned

totaam · 2013-10-17T08:46:15Z

2013-10-17 08:46:15: totaam changed priority from major to critical

totaam · 2013-10-17T08:46:15Z

2013-10-17 08:46:15: totaam commented

priority for 0.12

totaam · 2014-01-20T11:11:22Z

2014-01-20 11:11:22: totaam commented

Re-scheduling because of lack of demand for this.

totaam · 2014-08-19T05:03:58Z

2014-08-19 05:03:58: totaam commented

Scheduling for 0.16 - see also #668, #759

totaam · 2015-05-27T18:13:24Z

2015-05-27 18:13:24: antoine commented

r9532 deals with setxkbmap. Setting the keymap is now done fully through our existing X11 server connection without execing any new processes.

I will need to do more testing with "exotic" keyboard layouts to see if the call we had to xkbcomp should have been preserved. (in which case this would have to be re-written using Cython too - I hope not, the xkbcomp source code is scary)

totaam · 2015-06-07T20:53:09Z

2015-06-07 20:53:09: antoine edited the issue description

totaam · 2015-06-19T09:39:28Z

2015-06-19 09:39:28: antoine changed priority from critical to blocker

totaam · 2015-06-19T09:39:28Z

2015-06-19 09:39:28: antoine commented

Blocker for #817, see also #824, #759, #923, #939?

totaam · 2015-10-30T09:51:12Z

2015-10-30 09:51:12: antoine changed status from assigned to new

totaam · 2015-10-30T09:51:12Z

2015-10-30 09:51:12: antoine changed owner from antoine to afarr

totaam · 2015-10-30T09:51:12Z

2015-10-30 09:51:12: antoine commented

Done some testing with "fr" layout, couldn't break it.

@afarr: can you?

totaam · 2015-10-30T19:11:17Z

2015-10-30 19:11:17: maxmylyn commented

Tested with a myriad of layouts with a Win8.1 trunk r11099 client against a Fedora 21 trunk r11099 Server:

Couldn't break it...although the system didn't recognize my Georgian input..probably because I don't have that keyboard or language enabled on the server....Russian worked though.

I could spend a lot more time with more keyboard layouts and writing systems, but for all the ones that share a writing system with English (fr, de(Schweiz, Deutschland), dk, etc) it appears to be working just fine.

totaam · 2015-10-30T19:24:35Z

2015-10-30 19:24:35: maxmylyn commented

Found a minor issue:

With the English-International keyboard layout, inputting " (by hitting " twice) gives me ¨ on the server through Xpra.

totaam · 2015-10-31T01:15:50Z

2015-10-31 01:15:50: afarr commented

Gave it a little run with osx (0.16 r11077) - Hebrew worked as well as I could tell, Farsi looked good (though I wasn't sure about some of the Apple transliteration choices... not the keyboard's fault though), and Spanish seemed alright - osx key mappings aside, again.

totaam · 2015-11-02T05:17:39Z

2015-11-02 05:17:39: antoine commented

With the English-International keyboard layout, inputting " (by hitting " twice) gives me ¨ on the server through Xpra.
[[BR]]
That doesn't sound like too much of a problem.
It's worth checking which input methods are in use, if any. And maybe try a different one: see #634.

Also, it may be worth testing #817 at the same time.

totaam · 2015-11-05T00:58:24Z

2015-11-05 00:58:24: afarr commented

Testing inputting with Hebrew and Spanish keyboard layouts with windows 8.1, as long as the language is set before connection (see #817, regarding changing keyboard input layout "on the fly" with windows clients).

I took a quick stab at setting --input-method=uim, which seemed to behave about the same. Not sure how to check what input methods are being used without the use of flags to set them explicitly though.

totaam · 2015-11-13T01:39:18Z

2015-11-13 01:39:18: afarr commented

Interesting... I tried to use Hindi keyboard layout (HI - Hindi traditional layout).

Followed steps suggested at https://fedoraproject.org/wiki/I18N/Language_Support_Using_Yum to install the support on the fedora 21 vm (sudo yum groupinstall hindi-support & sudo yum langinstall hi_IN).

Installed the keyboard layout.

Set things up, switched keyboard layout, connected to a session.

I wasn't able to input any Devanagari script characters into a browser, an xterm, or a gedit application - but I was able to input them into the Run command buffer of the tray menu (typing 'xterm' in as 'ंूाीस' was not successful in launching anything, unsurprisingly).

Reconnecting with -d keyboard, the keyboard key 'k' (which does correctly correspond to 'क', for what that's worth) outputs the following client side:
2015-11-12 17:16:12,841 parse_key_event(<gtk.gdk.Event at 06496590: GDK_KEY_PRESS keyval=U+0915>, True)=<GTKKeyEvent object, contents: {'modifiers': ['mod2'], 'group
': 0, 'string': '', 'keyname': 'U+0915', 'pressed': True, 'keyval': 16779541, 'keycode': 75}>
2015-11-12 17:16:12,841 handle_key_action(GLClientWindow(10 : gtk2.GLWindowBacking(10, (900, 700), None)), <GTKKeyEvent object, contents: {'modifiers': ['mod2'], 'gr
oup': 0, 'string': '', 'keyname': 'U+0915', 'pressed': True, 'keyval': 16779541, 'keycode': 75}>) wid=10
2015-11-12 17:16:12,841 send_key_action(10, <GTKKeyEvent object, contents: {'modifiers': ['mod2'], 'group': 0, 'string': '', 'keyname': 'U+0915', 'pressed': True, 'k
eyval': 16779541, 'keycode': 75}>)
2015-11-12 17:16:13,013 mask_to_names(<flags 0 of type GdkModifierType>) GetKeyState(VK_NUMLOCK)=1, names=['mod2']
2015-11-12 17:16:13,013 parse_key_event(<gtk.gdk.Event at 064966B0: GDK_KEY_RELEASE keyval=U+0915>, False)=<GTKKeyEvent object, contents: {'modifiers': ['mod2'], 'gr
oup': 0, 'string': '', 'keyname': 'U+0915', 'pressed': False, 'keyval': 16779541, 'keycode': 75}>
2015-11-12 17:16:13,029 handle_key_action(GLClientWindow(10 : gtk2.GLWindowBacking(10, (900, 700), None)), <GTKKeyEvent object, contents: {'modifiers': ['mod2'], 'gr
oup': 0, 'string': '', 'keyname': 'U+0915', 'pressed': False, 'keyval': 16779541, 'keycode': 75}>) wid=10
2015-11-12 17:16:13,029 send_key_action(10, <GTKKeyEvent object, contents: {'modifiers': ['mod2'], 'group': 0, 'string': '', 'keyname': 'U+0915', 'pressed': False, '
keyval': 16779541, 'keycode': 75}>)
Server side:
2015-11-12 17:27:53,650 get_keycode(75, U+0915, ('mod2',)) is_native_keymap=False, found using translation: 145
2015-11-12 17:27:53,652 handle_key(2,True,U+0915,16779541,145,('mod2',)) keyboard_sync=True
2015-11-12 17:27:53,652 is_modifier(145) not found
2015-11-12 17:27:53,653 handle keycode pressing 145: key U+0915
2015-11-12 17:27:53,653 fake_key(145, True)
2015-11-12 17:27:53,656 scheduling key repeat timer with delay 500 for U+0915 / 145
2015-11-12 17:27:53,778 get_keycode(75, U+0915, ('mod2',)) is_native_keymap=False, found using translation: 145
2015-11-12 17:27:53,779 handle_key(2,False,U+0915,16779541,145,('mod2',)) keyboard_sync=True
2015-11-12 17:27:53,779 is_modifier(145) not found
2015-11-12 17:27:53,780 handle keycode unpressing 145: key U+0915
2015-11-12 17:27:53,780 fake_key(145, False)
2015-11-12 17:27:56,720 _clear_keys_pressed()
It looks like this language/keyboard mapping isn't being found by the server? (Do you need/reluctantly want the full log output of a connection with that keyboard input setting to check on this?... looking through it myself, it looks like there is no recognition of the characters - just numerical values assigned to keyvals.)

(More searching among "exotic" layouts to come.)

totaam · 2015-11-20T05:22:50Z

2015-11-20 05:22:50: antoine commented

The keycode is being found:
get_keycode(75, U+0915, ('mod2',)) is_native_keymap=False, found using translation: 145
You should be able to see this key mapping on the server with:
./xpra/gtk_common/keymap.py  | grep 145
Or
xmodmap -pke | grep 145

totaam · 2015-11-20T19:59:01Z

2015-11-20 19:59:01: afarr changed owner from afarr to antoine

totaam · 2015-11-20T19:59:01Z

2015-11-20 19:59:01: afarr commented

Interestingly, when I run ./xpra/gtk_common/keymap.py | grep 145, I get no response from the server.

When I run xmodmap -pke | grep 145, on the other hand, it does seem to recognize the mapping: keycode 145 = 0x0915 0x0916 0x0915 0x0916 0x0915 0x0916

I still can't get the Hindi or Sanskrit characters (Devanagari) to display - but judging from the searches I've done on the subject, I'm not alone in that failure.

I haven't been able to find any other issues with any "exotic" keyboard layouts with the new xkbcommon code though. Handing this back - looks ready to close.

totaam · 2015-11-22T06:58:23Z

2015-11-22 06:58:23: antoine changed status from new to closed

totaam · 2015-11-22T06:58:23Z

2015-11-22 06:58:23: antoine set resolution to fixed

totaam · 2015-11-22T06:58:23Z

2015-11-22 06:58:23: antoine commented

I get no response from the server.
[[BR]]
My guess is that you didn't run it against the display. You have to run this command within an xterm started in the session, or manually set the DISPLAY.

Closing. If we get bug reports about specific layouts, we can make new tickets and point back here.

totaam · 2015-12-09T05:25:52Z

2015-12-09 05:25:52: antoine changed component from server to keyboard

totaam · 2015-12-09T05:25:52Z

2015-12-09 05:25:52: antoine changed title from xkbcommon code to replace core keyboard and xkb calls to use X11 keyboard API instead of execing new processes

totaam · 2015-12-09T05:25:52Z

2015-12-09 05:25:52: antoine commented

Clarification: this only dealt with making API calls, actual Xkb will be dealt with in #1049.

totaam closed this as completed Nov 22, 2015

This was referenced Jan 22, 2021

seccomp security support #622

Open

Hard to switch keyboard layout using hot keys; "Keyboard" menu has no effect #661

Closed

This was referenced Jan 22, 2021

keyboard language input change during sessions #817

Closed

use Xkb for keyboard mapping #1049

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use X11 keyboard API instead of execing new processes #371

use X11 keyboard API instead of execing new processes #371

totaam commented Jul 6, 2013

totaam commented Jul 16, 2013

totaam commented Oct 17, 2013

totaam commented Oct 17, 2013

totaam commented Jan 20, 2014

totaam commented Aug 19, 2014

totaam commented May 27, 2015

totaam commented Jun 7, 2015

totaam commented Jun 19, 2015

totaam commented Jun 19, 2015

totaam commented Oct 30, 2015

totaam commented Oct 30, 2015

totaam commented Oct 30, 2015

totaam commented Oct 30, 2015

totaam commented Oct 30, 2015

totaam commented Oct 31, 2015

totaam commented Nov 2, 2015

totaam commented Nov 5, 2015

totaam commented Nov 13, 2015

totaam commented Nov 20, 2015

totaam commented Nov 20, 2015

totaam commented Nov 20, 2015

totaam commented Nov 22, 2015

totaam commented Nov 22, 2015

totaam commented Nov 22, 2015

totaam commented Dec 9, 2015

totaam commented Dec 9, 2015

totaam commented Dec 9, 2015

use X11 keyboard API instead of execing new processes #371

use X11 keyboard API instead of execing new processes #371

Comments

totaam commented Jul 6, 2013

2013-07-06 09:26:12: antoine created the issue

totaam commented Jul 16, 2013

2013-07-16 06:43:55: antoine changed status from new to assigned

totaam commented Oct 17, 2013

2013-10-17 08:46:15: totaam changed priority from major to critical

totaam commented Oct 17, 2013

2013-10-17 08:46:15: totaam commented

totaam commented Jan 20, 2014

2014-01-20 11:11:22: totaam commented

totaam commented Aug 19, 2014

2014-08-19 05:03:58: totaam commented

totaam commented May 27, 2015

2015-05-27 18:13:24: antoine commented

totaam commented Jun 7, 2015

2015-06-07 20:53:09: antoine edited the issue description

totaam commented Jun 19, 2015

2015-06-19 09:39:28: antoine changed priority from critical to blocker

totaam commented Jun 19, 2015

2015-06-19 09:39:28: antoine commented

totaam commented Oct 30, 2015

2015-10-30 09:51:12: antoine changed status from assigned to new

totaam commented Oct 30, 2015

2015-10-30 09:51:12: antoine changed owner from antoine to afarr

totaam commented Oct 30, 2015

2015-10-30 09:51:12: antoine commented

totaam commented Oct 30, 2015

2015-10-30 19:11:17: maxmylyn commented

totaam commented Oct 30, 2015

2015-10-30 19:24:35: maxmylyn commented

totaam commented Oct 31, 2015

2015-10-31 01:15:50: afarr commented

totaam commented Nov 2, 2015

2015-11-02 05:17:39: antoine commented

totaam commented Nov 5, 2015

2015-11-05 00:58:24: afarr commented

totaam commented Nov 13, 2015

2015-11-13 01:39:18: afarr commented

totaam commented Nov 20, 2015

2015-11-20 05:22:50: antoine commented

totaam commented Nov 20, 2015

2015-11-20 19:59:01: afarr changed owner from afarr to antoine

totaam commented Nov 20, 2015

2015-11-20 19:59:01: afarr commented

totaam commented Nov 22, 2015

2015-11-22 06:58:23: antoine changed status from new to closed

totaam commented Nov 22, 2015

2015-11-22 06:58:23: antoine set resolution to fixed

totaam commented Nov 22, 2015

2015-11-22 06:58:23: antoine commented

totaam commented Dec 9, 2015

2015-12-09 05:25:52: antoine changed component from server to keyboard

totaam commented Dec 9, 2015

2015-12-09 05:25:52: antoine changed title from xkbcommon code to replace core keyboard and xkb calls to use X11 keyboard API instead of execing new processes

totaam commented Dec 9, 2015

2015-12-09 05:25:52: antoine commented