New video card, and all XPRA windows are dark

[totaam]

Issue migrated from trac ticket # 2101

component: client | priority: major | resolution: fixed

2019-01-08 18:52:46: nathan_lstc created the issue

---

The card is a quadro p2000. I am using windows 10. I am using the beta client from the XPRA web site.

The NVIDIA control panel (not XPRA settings) lets me switch between "YCbCr422" "YCbCr444" and "RGB" for "output color format" (this is in the "Change Resolution" pane). The XPRA window is dark unless I chose YCbCr422 with 8bpc for "Output color depth". With 10bpc and YCbCr422 XPRA becomes darker than the rest of the screen.

The issue is not exclusively actuated by the "bpc" settings, but also by the "output color format". It is dark with both 10 and 8 for YCbCr444 and for RGB.

when I choose YCbCr422 (which was, weirdly, the default) some things, like thin text, looked distorted. This distortion is a global property of that setting affecting all windows. The distortion reminds of a CRT with bad color convergence, really weird, but text looks great with RGB or YCbCr444 on my screen (wide-format display-port samsung OLED), so I really don't want to use that setting, but unless I use that setting XPRA is darker than the rest of the screen..

Screenshots of the XPRA looks perfect. Namely, they are not darker than the rest of the screen. Specifically, screenshots of the XPRA window look less dark than the window itself.

I am going to attach a photo that I took on my cell phone.

[totaam]

2019-01-08 18:54:37: nathan_lstc uploaded file IMG_0251.jpg (86.7 KiB)

[totaam]

2019-01-08 18:56:46: nathan_lstc uploaded file Capture.PNG (61.5 KiB)

The NVIDIA control I mention

[totaam]

2019-01-09 14:29:05: antoine changed owner from antoine to nathan_lstc

[totaam]

2019-01-09 14:29:05: antoine commented

---

Inlining the pictures:

• The NVIDIA control:
  [[Image(Capture.PNG)]]

• The darker xpra window:
  [[Image(IMG_0251.jpg)]]

---

This is probably related to ImageDepth and in particular #1309.

Can you post the log output with -d opengl?
There should be some relevant details in init_formats() during window initialization.

Until I can fix this, you can disable opengl in the client, which may become a lot slower..

What is probably needed to fix this:

• either we should not be trying to use 10 bpc in the client (especially if the server doesn't export pixel data with high bit depth) - or at least give the option to use 8 bpc instead
• fix the upsampling / rendering so 8 bpc data is rendered correctly on a 10 bpc display.

It is dark with both 10 and 8 for YCbCr444 and for RGB.
That's weird, I would not expect standard 8-bit modes to have any problems. RGB and YCbCr444 are equivallent and lossless.

when I choose YCbCr422 (which was, weirdly, the default) some things, like thin text, looked distorted.
This distortion is a global property of that setting affecting all windows. The distortion reminds of a CRT with bad color convergence, really weird
That's expected due to the horizontal subsampling of chroma.
Can you post a screenshot or picture to be sure?

[totaam]

2019-01-09 23:40:18: nathan_lstc commented

---

[[Image(IMG_0255.jpg)]]
[[Image(IMG_0256.jpg)]]

By color convergence problems affecting "all windows" I meant everything on the system, not just XPRA. I think you are right about cause. I have uploaded some photos of YCbCr422 (first picture) vs YCbCr422 (second)

However, only the XPRA windows are dark.

[totaam]

2019-01-09 23:40:39: nathan_lstc uploaded file IMG_0255.jpg (29.2 KiB)

[totaam]

2019-01-09 23:40:59: nathan_lstc uploaded file IMG_0256.jpg (30.5 KiB)

[totaam]

2019-01-10 00:45:40: nathan_lstc commented

---

I'm attaching two opengl logs:

[[YCbCr444.log]]
[[YCbCr422.log]]

[totaam]

2019-01-10 00:46:30: nathan_lstc uploaded file YCbCr422.log (50.5 KiB)

-d opengl with output color format set to 422

[totaam]

2019-01-10 00:46:46: nathan_lstc uploaded file YCbCr444.log (65.7 KiB)

-d opengl with output color format set to 444

[totaam]

2019-01-10 00:53:21: nathan_lstc commented

---

Everything started working correctly when I switched "HDR and WCG" to "off" in settings (this is windows settings not the nvidia-control panel). See screenshot.

[[Image(c1.PNG)]]

When "HDR and "WCG" is on and color is 10bit 422 or 8 or 10 444 or RGB with "HDR an WCG" on in settings control panel XPRA is darker than everything else, but I also got a nice brightness slider in the windows settings.

[totaam]

2019-01-10 00:53:45: nathan_lstc uploaded file c1.PNG (26.6 KiB)

[totaam]

2019-01-10 19:48:31: nathan_lstc commented

---

Another interesting thing: the brightness of the XPRA window is immune to the windows HDR brightness slider.

[totaam]

2019-01-10 19:57:53: nathan_lstc commented

---

Another detail: "native" opengl works great. This problem only pops up with gtk opengl.

[totaam]

2019-01-11 13:29:03: antoine commented

---

Another detail: "native" opengl works great. This problem only pops up with gtk opengl.
Very interesting, the naive solution would be to switch the default to "native", since that's also going to be the default for GTK3.

But this may in fact hinder us in the long run if the "native" option doesn't support HDR properly. Maybe it does already, I really don't know much about it.
We have a ticket for X11 server HDR support: #1584

Can you attach the -d opengl log output of both "native" and "gtk" backends?

[totaam]

2019-01-11 19:05:56: nathan_lstc commented

---

I'm guessing it has something to with the 48-bit color that XPRA detects:

* gdkgl
  - version                       : 10.0
* gdkglext
  - version                       : 1.2.0
* green-size                      : 16
* gtkglext
  - version                       : 1.2.0
* has-depth-buffer                : True
* has-stencil-buffer              : False
* has_alpha                       : True
* max-viewport-dims               : 32768, 32768
* opengl                          : 4, 6
* pygdkglext
  - version                       : 1.0.0
* pyopengl                        : 3.1.1a1
* red-size                        : 16
* renderer                        : Quadro P2000/PCIe/SSE2
* rgba                            : True
* safe                            : True
* sample-buffers                  : 0
* samples                         : 0
* shading-language-version        : 4.60 NVIDIA
* stencil-size                    : 0
* stereo                          : False
* texture-size-limit              : 32768
* transparency                    : False
* vendor                          : NVIDIA Corporation
* zerocopy                        : True

nathan@coyote2 MINGW64 ~/src

See slide 54 of:

http://on-demand.gputechconf.com/gtc/2017/presentation/s7394-tom-true-programming-for-high-dynamic-range.pdf

[totaam]

2019-01-13 13:10:31: antoine commented

---

Can you attach the -d opengl log output of both "native" and "gtk" backends?

[totaam]

2019-01-13 14:01:51: nathan_lstc commented

---

I think you are right about GTK supporting HDR somehow. The brightness slider only changes SDR windows according to its embedded description. With GTK on my HDR setup XPRA is always darker than the rest of the screen (unless I slide brightness below 10%), but is also immune from the brightness bar, which is only supposed to affect SDR windows.

Regarding logs, I'll do that when I get to work on Monday. My equipment at home isn't nice enough to let me test HDR. :)

[totaam]

2019-01-14 19:27:38: nathan_lstc commented

---

Added.

• [/attachment/ticket/2101/native.log native]

• [/attachment/ticket/2101/gtk.log gtk]

[totaam]

2019-01-14 19:28:26: nathan_lstc uploaded file native.log (81.7 KiB)

[totaam]

2019-01-14 19:28:37: nathan_lstc uploaded file gtk.log (83.2 KiB)

[totaam]

2019-01-17 12:25:15: antoine commented

---

Key bits:

• init format is identical:

init_formats() texture pixel format=GL_RGB, internal format=RGB8, \
    rgb modes=['YUV420P', 'YUV422P', 'YUV444P', 'GBRP', 'BGRA', 'BGRX', 'RGBA', 'RGBX', 'RGB', 'BGR']

But then:

• native:

ChoosePixelFormat for window 0x350834 and 8 bpc: 0x10
DescribePixelFormat: {'accum-size': 64, 'alpha-shift': 24, 'aux-buffers': 4, \
    'red-size': 8, 'blue-shift': 0, 'red-shift': 16, 'stencil-size': 8, \
    'green-shift': 8, 'blue-size': 8, 'accum-green-size': 16, 'alpha-size': 8, \
    'double-buffered': True, 'depth-size': 0, 'green-size': 8, 'accum-red-size': 16, \
    'depth': 32, 'accum-blue-size': 16, 'rgba': True, 'visible-mask': 0L}

• gtk:

Config_new_by_mode(<flags GDK_GL_MODE_DOUBLE | GDK_GL_MODE_ALPHA of type GdkGLConfigMode>)=<gtk.gdkgl.Config object at 0x739aaa0 (GdkGLConfigImplWin32 at 0x3f079a0)>
GL props={'gdkglext': {'version': (1, 2, 0)}, 'has-depth-buffer': True, 'accum-blue-size': 0, \
    'stencil-size': 0, 'blue-size': 16, 'gdkgl': {'version': (6, 2)}, 'double-buffered': True, \
    'depth-size': 24, 'sample-buffers': 0, 'gtkglext': {'version': (1, 2, 0)}, \
    'alpha-size': 16, 'rgba': True, 'display_mode': ['ALPHA', 'DOUBLE'], 'samples': 0, \
    'red-size': 16, 'has-stencil-buffer': False, 'has_alpha': True, 'pygdkglext': {'version': (1, 0, 0)}, \
    'stereo': False, 'accum-green-size': 0, 'green-size': 16, 'accum-red-size': 0, 'depth': 48, 'aux-buffers': 4}

The key difference here is that "gtk" chooses a 16-bit per channel mode whereas "native" uses 8-bit.
We use ChoosePixelFormat with bpc = 8 in create_wgl_context.
It seems that 16-bit per channel modes default to HDR then? (docs are not clear on that - it is implied)

So r21382 will now prefer "native" over "gtk".
@nathan_lstc: does that make sense, can I close?

---

At some point when we want to support HDR, we will need to use 16-bit per channel AND either:

• for SDR content: tell mswindows that the content we paint is SDR? (not sure how in opengl)
• use HDR and make sure that pixel buffers carry the colourspace information (and convert SDR to HDR when needed)

Opengl links:

• learnopengl Advanced-Lighting HDR
• glfw: Support HDR and wide color gamut
• Displaying HDR Nuts and Bolts

Microsoft docs: High Dynamic Range and Wide Color Gamut.

[totaam]

2019-01-23 22:55:01: nathan_lstc commented

---

I'm satisfied. I've something else to add here: the examples from pygtkglext behave just like XPRA, so other things are affected as well.

[totaam]

2019-01-23 23:19:51: nathan_lstc commented

---

I've found some a glgears written using gtkglext-win32 and I cannot find any attribs for gdk_gl_config_new that get 8 bits per channel. Passing in "8" for GDK_GL_RED_SIZE seems to have no effect.

[totaam]

2019-01-24 05:26:10: antoine changed status from new to closed

[totaam]

2019-01-24 05:26:10: antoine set resolution to fixed

[totaam]

2019-01-24 05:26:10: antoine commented

---

I'm not going to backport this to 2.4.x, the fix will be in 2.5 only.

We'll revisit HDR in #1584.