Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 10 bit formats to virtualgl #1577

Closed
totaam opened this issue Jul 12, 2017 · 9 comments
Closed

add 10 bit formats to virtualgl #1577

totaam opened this issue Jul 12, 2017 · 9 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Jul 12, 2017

Issue migrated from trac ticket # 1577

component: packaging | priority: major | resolution: fixed

2017-07-12 13:07:34: antoine created the issue


Follow up from #1309.

Without this, it is quite difficult to use the 10 bpc mode.
You get with glxgears:

Error: couldn't get an RGB, Double-buffered visual

AFAICT, this shouldn't be too hard: we don't want anything fancy, no compression support.

@totaam
Copy link
Collaborator Author

totaam commented Jul 20, 2017

2017-07-20 18:06:26: antoine changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Jul 20, 2017

2017-07-20 18:06:26: antoine commented


Worth a try, may not be too hard.

@totaam
Copy link
Collaborator Author

totaam commented Jul 28, 2017

2017-07-28 10:34:07: antoine uploaded file vgl-30bpc.patch (8.0 KiB)

patch with debug which adds 30bpc to the X11 transport

@totaam
Copy link
Collaborator Author

totaam commented Jul 28, 2017

2017-07-28 10:34:23: antoine uploaded file vgl-30bpc-minimal.patch (4.2 KiB)

minimal patch

@totaam
Copy link
Collaborator Author

totaam commented Jul 28, 2017

2017-07-28 10:40:41: antoine commented


The patch above applies cleanly to current virtualgl 2.5.3 and allows us to forward "r210" pixel data as GL_RGB10_A2 / GL_UNSIGNED_INT_2_10_10_10_REV.

Tested with #1553 and the commands:

  • server:
xpra start --start-child=xterm --pixel-depth=30
  • client: xpra attach
  • test app:
vglrun -d :1 python xpra/client/gtk_base/example/gl_colors_gradient.py

The changes in banding are very noticeable when going from 10 down to 8.

Edit: made a pull request for upstream.

@totaam
Copy link
Collaborator Author

totaam commented Oct 24, 2017

2017-10-24 17:11:13: antoine commented


Latest comment: This unfortunately required more in-depth modifications to VirtualGL, which led me down the rabbit hole of overhauling all of the horribly outdated pixel format and conversion stuff. I should have it checked in by the end of this week.

@totaam
Copy link
Collaborator Author

totaam commented Oct 26, 2017

2017-10-26 05:36:42: antoine changed status from assigned to closed

@totaam
Copy link
Collaborator Author

totaam commented Oct 26, 2017

2017-10-26 05:36:42: antoine set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Oct 26, 2017

2017-10-26 05:36:42: antoine commented


Merged: This has been implemented in the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant