Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to async/await and async glob #137

Merged
merged 4 commits into from
Jul 20, 2021
Merged

Switch to async/await and async glob #137

merged 4 commits into from
Jul 20, 2021

Conversation

GeoSot
Copy link
Collaborator

@GeoSot GeoSot commented Mar 8, 2021 •
edited
Loading

Fixes #8

TODO:

  • Add a sync API method too
    • re-create package.lock using npm 6
  • Update README.md with the changes
  • Drop Node 10 Tests
  • Revisit the sync API solution, ideally without a package
  • Rebase/squash any patches manually before the final merge

@GeoSot GeoSot marked this pull request as draft March 8, 2021 11:00
@GeoSot GeoSot marked this pull request as ready for review March 8, 2021 13:23
@XhmikosR XhmikosR changed the title Uses promises to read Scss files Switch to async/await and async glob Mar 10, 2021
@danny007in
Copy link

check this for fast declared variables finding postcss/postcss-scss#120

@danny007in
Copy link

@GeoSot also implement #115 and #125 in this PR

@GeoSot
Copy link
Collaborator Author

GeoSot commented Apr 5, 2021

@danny007in better on a future PR. I have created the basis for these, but prefer to implement them in separate

GeoSot and others added 2 commits July 20, 2021 17:24
@GeoSot @XhmikosR
Add sync API method
0814a9b 
Rename sync function to `find` and async to `findAsync` to keep compatibility
@XhmikosR
CI: drop Node.js 10 support
67f5e69
@XhmikosR XhmikosR merged commit 255575c into main Jul 20, 2021
@XhmikosR XhmikosR deleted the async-index-js branch July 20, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to async functions
3 participants
@GeoSot @danny007in @XhmikosR