feat: display tracking information about unused variables #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2021
Closed
danny007in
reviewed
Jan 30, 2021
gentzeng
referenced
this pull request
Jan 31, 2021
Breaking Change Co-Authored-By: Georg Gentzen <60478031+gentzeng@users.noreply.github.com>
137e4e1 to
300b76f
Compare
danny007in
reviewed
Jan 31, 2021
danny007in
suggested changes
Jan 31, 2021
index.js
Outdated
| total: variables.length, | ||
| unusedOrigin: unusedVarsOrigin, | ||
| // for backwards compatibility of API | ||
| unused: unusedVarsOrigin.map(({ name }) => name) |
There was a problem hiding this comment.
unused should above only, plz do not make more complicated code
There was a problem hiding this comment.
We need to keep the original 'unused' as an array containing only the variable names, as well as total being the amount of all variables, since I don't want to break the API of this function. Hence the additional return value for more information.
There was a problem hiding this comment.
Furthermore, I think its convenient to see not only the amount of all variables, but of the unused as well
4117c18 to
9fe401c
Compare
danny007in
approved these changes
Jan 31, 2021
|
@gentzeng rebase it |
d83753e to
83e74ed
Compare
Unused variables are grouped per containig files and displayed with line and column information. Files are displayed relatively to working directory. In addition to total amount of variables, amount of unused variables gets also displayed. fix(app.js): Fixed file according to xo linting rules feat: print enhanced information of unused variable line and column of unused variable with respect to all files of one regarded directory, i.e., within concatenation of all those files, are printed fix: line Info of variable now gets displayed per containing file fix: unused variables are grouped per containing file feat: display path of files containing unused variables relatively fix: added newline before files containing UVs are displayed stlye(cli.js): put console.log command on more lines refactor(index.js): refactored calculation of variable Lines per File fix(cli.js): exchanged manual ansi escape code with chalk command fix: Deleted wrongfully copied directory fix(README.md): Updated README.md fix(): incorporated ideas from PR XhmikosR#124 Co-Authored-By: Daniel <50356015+danny007in@users.noreply.github.com>
83e74ed to
4e2b3ee
Compare
|
Done |
danny007in
reviewed
Mar 6, 2021
| @@ -5,27 +5,32 @@ const Declaration = require('postcss/lib/declaration'); | |||
| const Comment = require('postcss/lib/comment'); | |||
| let fusvEnabled = true; | |||
|
|
|||
| function parseNodes(nodes, variables, ignoreList) { | |||
| function parseNodes(nodes, variables, ignoreList, file = '') { | |||
There was a problem hiding this comment.
carefully adapt this
#134 (comment)
for file = '')
6 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature and not a breaking change
Unused variables are grouped per containig files and displayed with line
and column information. Files are displayed relatively to working
directory. In addition to total amount of variables, amount of unused
variables gets also displayed.
This feature heavily incorporates ideas from PR #124.
Co-Authored-By: Daniel 50356015+danny007in@users.noreply.github.com