Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to async functions #8

Closed
XhmikosR opened this issue Dec 13, 2017 · 3 comments · Fixed by #137
Closed

Switch to async functions #8

XhmikosR opened this issue Dec 13, 2017 · 3 comments · Fixed by #137
Labels
enhancement help wanted

Comments

@XhmikosR
Copy link
Owner

XhmikosR commented Dec 13, 2017 •
edited
Loading

Except for fs.existsSync which isn't deprecated, but including glob.

EDIT:
We might need to switch to globby too.

Also, we should probably keep a fusv.sync method.

EDIT2: we can keep glob and use util.promisify probably.
@Johann-S
Copy link
Collaborator

Sorry to ask but what's the reason to switch to async functions ?

@XhmikosR
Copy link
Owner Author

https://nodejs.org/en/docs/guides/blocking-vs-non-blocking/

@Johann-S
Copy link
Collaborator

Maybe pify can help us ? https://github.com/sindresorhus/pify

@XhmikosR XhmikosR mentioned this issue Mar 4, 2021
Closed
@XhmikosR XhmikosR mentioned this issue Mar 10, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to async/await and async glob XhmikosR/find-unused-sass-variables
2 participants
@XhmikosR @Johann-S