Trouble upgrading from PHP7 to PHP8

[geoidesic]

I have a weird scenario where my xero integration works in PHP7 but the same codebase doesn't work in PHP8. On PHP8 it will authenticate against Xero's Oauth2 successfully but requests made to the Xero API always fail with invalid_grant. I'm struggling to figure out why exactly. Any clues?

[rodjsta]

Without specific code to review, the best approach is to note that this question has been asked frequently online, with various answers depending on the context. I suggest reviewing those first and then returning here if further clarification is needed.

[geoidesic]

Thank for the response. I tried searching through issues. I couldn't find anything at all related. Perhaps I don't now what search term to use. I tried "PHP7" I tried "PHP8". I also tried Google etc. searching for "Trouble upgrading from PHP7 to PHP8 xero oauth2" – I'm not sure what else to try?

In terms of code. Here's the endpoint that's no longer working (it's a CakePHP 4.x controller):

    public function getAccountCode()
    {

        $this->autoRender = false;  

        $params = $this->request->getParsedBody();
        $queryParams = $this->request->getQueryParams();
        $personId = $params['userId'];

        $xeroAccountTable = TableRegistry::getTableLocator()->get("xeroaccounts");
        $authData = $xeroAccountTable->find('all', [
            'conditions' => ['person_id' => $personId]
        ])->first();

        if ($authData) {
            $xeroAuth = Configure::consume('XeroAuth');
            $provider = new \League\OAuth2\Client\Provider\GenericProvider($xeroAuth);

            $newAccessToken = $provider->getAccessToken('refresh_token', [
                'refresh_token' => $authData['refresh_token']
            ]);

            $fieldData = ['access_token' => $newAccessToken->getToken(), 'refresh_token' => $newAccessToken->getRefreshToken(), 'expired' => false];
            $condition = ['person_id' => $personId];
            $res = $xeroAccountTable->updateAll($fieldData, $condition);

            $config = \XeroAPI\XeroPHP\Configuration::getDefaultConfiguration()->setAccessToken($newAccessToken->getToken());
            $accountingApi = new \XeroAPI\XeroPHP\Api\AccountingApi(
                new \GuzzleHttp\Client(),
                $config
            );

            //- filters
            $where = 'Status=="ACTIVE" AND (SystemAccount==null OR SystemAccount=="")';
            if ($queryParams) {
                foreach ($queryParams as $key => $val) {
                    $where .= ' AND ' . $key . '=="' . $val . '"';
                }
            }

            $accountList = $accountingApi->getAccounts($authData['tenant_id'], null, $where);

         
            $resp = array(
                "accountData" => $accountList,
            );
            $response = $this->response->withType('application/json');
            return $response->withStringBody(json_encode($resp));
        } else {
            return $this->response->withStatus(403)->withType('application/json')
                ->withStringBody(json_encode(['error' => 'This page requires an active Xero authorisation. Either your authorisation token has expired or does not exist.']));
        }
    }

Here's the library entry from composer.json

        "xeroapi/xero-php-oauth2": "2.23.0"

I've gone from PHP v7.4.33 to v8.3.15. No changes were made to the codebase for the upgrade as the code was already PHP8 compliant.

[rodjsta]

Searching for 'invalid_grant xero api' should yield you some results. However, I think your problem may be solved by adding 'grant_type' => 'refresh_token' here:

$newAccessToken = $provider->getAccessToken('refresh_token', [
    'grant_type' => 'refresh_token',
    'refresh_token' => $auth_token->refresh_token,
]);

I would also suggest adding (if not already) offline_access to the scopes.

[geoidesic]

Thanks – I tried all of that. No change. I just cannot get it to work in PHP8 at all. I've had better luck writing my own direct connection to the Xero API via guzzle. I even tried the newer version of this library, 7.3.0 – can't get it to work at all either.

[geoidesic]

I tried v7.3.0 and I can't get the callback to work there (it works with v2.x) on PHP8.

Here are the logs from my attempt:

2024-12-19 14:38:42 debug: [Controller.php:65 - XeroPlugin\Controller\XerosController::callback]:
Starting callback
2024-12-19 14:38:42 debug: [Controller.php:74 - XeroPlugin\Controller\XerosController::callback]:
Got code and state
2024-12-19 14:38:42 debug: [Controller.php:82 - XeroPlugin\Controller\XerosController::callback]:
State validated successfully
2024-12-19 14:38:42 debug: [Controller.php:88 - XeroPlugin\Controller\XerosController::callback]:
Code validation passed
2024-12-19 14:38:42 debug: [Controller.php:91 - XeroPlugin\Controller\XerosController::callback]:
Starting token exchange
2024-12-19 14:38:42 debug: [Controller.php:93 - XeroPlugin\Controller\XerosController::callback]:
Got Xero config
2024-12-19 14:38:42 debug: [Controller.php:94 - XeroPlugin\Controller\XerosController::callback]:
Array
(
    [clientId] => <REDACTED (but double checked)>
    [clientSecret] => <REDACTED (but double checked)>
    [redirectUri] => https://mnr-be.arc2dev.co.uk/xero-plugin/callback
    [urlAuthorize] => https://login.xero.com/identity/connect/authorize
    [urlAccessToken] => https://identity.xero.com/connect/token
    [urlResourceOwnerDetails] => https://api.xero.com/api.xro/2.0/Organisation
)


2024-12-19 14:38:42 debug: [Controller.php:96 - XeroPlugin\Controller\XerosController::callback]:
Created provider
2024-12-19 14:38:42 debug: [Controller.php:99 - XeroPlugin\Controller\XerosController::callback]:
Attempting to get access token
2024-12-19 14:38:43 debug: [Controller.php:146 - XeroPlugin\Controller\XerosController::callback]:
Exception caught in token exchange: invalid_grant
2024-12-19 14:38:43 debug: [Controller.php:155 - XeroPlugin\Controller\XerosController::callback]:
Xero OAuth Error: {
    "error": "invalid_grant",
    "error_description": "No additional details",
    "timestamp": "2024-12-19 14:38:43",
    "request_id": "xero_67642ff31a65c"
}

Here's the controller code:

try {
            xlog("Starting token exchange");
            $xeroConfig = Configure::consume('XeroAuth');
            xlog("Got Xero config");
            xlog($xeroConfig);
            $provider = new \League\OAuth2\Client\Provider\GenericProvider($xeroConfig);
            xlog("Created provider");
            xlog("Attempting to get access token");
            
            //<-- it dies when it tries to `getAccessToken` with the `invalid_grant` error.
            $accessToken = $provider->getAccessToken('authorization_code', [
                'code' => $code
            ]);

I can connect and interact with Xero API using the same credentials via POSTMAN

[geoidesic]

composer update fixed the callback error. That's a start.

[calcinai]

Not 100% on this, but it's also possible that upgrading PHP 7 > 8 would drag different peer dependencies, which possibly have different behaviour.

FWIW I made an oath provider a while back that definitely works. It could be a good guide to confirm your usage of the league/oauth2-client is consistent/complete.

Just guessing here but easy things to check.