Skip to content
This repository has been archived by the owner on Apr 12, 2021. It is now read-only.

Set paymentsOnly=true in xero api call for cash Journal #343

Closed
VyasNirav opened this issue Aug 29, 2018 · 6 comments
Closed

Set paymentsOnly=true in xero api call for cash Journal #343

VyasNirav opened this issue Aug 29, 2018 · 6 comments

Comments

@VyasNirav
Copy link
Contributor

VyasNirav commented Aug 29, 2018

Hi,
I want to get journals on cash basis so, I try "paymentsOnly=true" parameter in query but it's not work.

It will return me "No property or field 'paymentsOnly' exists in type 'Journal'"

var tempObj = api.Journals.where("paymentsOnly=true").find();

link : https://developer.xero.com/documentation/api/journals
Thank's

@MJMortimer
Copy link
Member

MJMortimer commented Aug 30, 2018

Hey @VyasNirav,

You can't set that parameter via the where clause and unfortunately it has not been implemented as a standalone parameter on the JournalsEndpoint yet.

Would like like to add a parameter to the JournalsEndpoint similar to the offset one?

@VyasNirav
Copy link
Contributor Author

Hey @MJMortimer ,

Thank you for reply.

Yes, Actually I want journals on a cash basis and for that I read the api document in Journal section it will suggest me that just set PaymentOnly parameter with true then it will return only cash basis journals

"Would like like to add a parameter to the JournalsEndpoint similar to the offset one?"
Yes or similar solution please.

Thank's

@MJMortimer
Copy link
Member

@VyasNirav would you be comfortable adding the functionality in a pull request?

@VyasNirav
Copy link
Contributor Author

Hey @MJMortimer ,

I pull request for this changes.

@MJMortimer
Copy link
Member

The functionality has been merged in PR #346. Thanks @VyasNirav

@VyasNirav
Copy link
Contributor Author

Thank's @MJMortimer

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants