Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix or remove build.ps1 #941

Closed
sungam3r opened this issue Feb 24, 2022 · 3 comments · Fixed by #1378
Closed

Fix or remove build.ps1 #941

sungam3r opened this issue Feb 24, 2022 · 3 comments · Fixed by #1378

Comments

@sungam3r
Copy link
Collaborator

This script still contains APPVEYOR_BUILD_NUMBER.
@sungam3r
Copy link
Collaborator Author

@carlosrecuero Are dotnet-install.ps1 and install-sdk.ps1 still needed?

@carlosrecuero
Copy link
Collaborator

Hi,

Sincerely I don't use them at all, but maybe there is some scenario of usage I don't know.

@unaizorrilla , what do you think?

@sungam3r sungam3r mentioned this issue Aug 8, 2022
Merged
@sungam3r
Copy link
Collaborator Author

Well... I think it's safe to remove these files now. No feedback from @unaizorrilla so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove appveyor config and assosiated ps files Xabaril/AspNetCore.Diagnostics.HealthChecks
2 participants
@carlosrecuero @sungam3r