From 73b0ecf0f09b80d9d501a79cde9e87551deca15d Mon Sep 17 00:00:00 2001 From: Mark Travis Date: Mon, 25 Sep 2023 16:28:26 -0700 Subject: [PATCH 1/5] Clarify definition of "network health." --- src/ripple/app/misc/FeeEscalation.md | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/ripple/app/misc/FeeEscalation.md b/src/ripple/app/misc/FeeEscalation.md index 30f4dc2784e..c105cdb97cc 100644 --- a/src/ripple/app/misc/FeeEscalation.md +++ b/src/ripple/app/misc/FeeEscalation.md @@ -190,9 +190,17 @@ lower) fee to get into the same position as a reference transaction. ### Consensus Health -For consensus to be considered healthy, the consensus process must take -less than 5 seconds. This time limit was chosen based on observed past -behavior of the network. Note that this is not necessarily the time between +For consensus to be considered healthy, the peers on the network +should largely remain in sync with one another. It is particularly +important for the validators to remain in sync, because they must +be in sync to participate in consensus. Another factor to consider is +the duration of the consensus process itself. This generally takes +under 5 seconds on the main network. This is based on historical +observations. However, some factors, such as transactions volumes, +can increase consensus duration. This is because rippled performs +more work as transaction volume increases. Under sufficient load this +tends to increase consensus duration. +Note that this is not necessarily the time between ledger closings, as consensus usually starts some amount of time after a ledger opens. From 2237f1d3707da0150e9fa955878aef367d4ee6a6 Mon Sep 17 00:00:00 2001 From: Mark Travis Date: Wed, 27 Sep 2023 17:03:45 -0700 Subject: [PATCH 2/5] Review fixes. --- src/ripple/app/misc/FeeEscalation.md | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/ripple/app/misc/FeeEscalation.md b/src/ripple/app/misc/FeeEscalation.md index c105cdb97cc..d4e5db41ebe 100644 --- a/src/ripple/app/misc/FeeEscalation.md +++ b/src/ripple/app/misc/FeeEscalation.md @@ -192,15 +192,19 @@ lower) fee to get into the same position as a reference transaction. For consensus to be considered healthy, the peers on the network should largely remain in sync with one another. It is particularly -important for the validators to remain in sync, because they must -be in sync to participate in consensus. Another factor to consider is +important for the validators to remain in sync, because that is required +for participation in consensus. However, the network tolerates some +validators being out of sync. Fundamentally, network health is a +function of validators reaching consensus on sets of recently submitted +transactions. +Another factor to consider is the duration of the consensus process itself. This generally takes under 5 seconds on the main network. This is based on historical observations. However, some factors, such as transactions volumes, can increase consensus duration. This is because rippled performs more work as transaction volume increases. Under sufficient load this tends to increase consensus duration. -Note that this is not necessarily the time between +Note that this is not necessarily the duration between ledger closings, as consensus usually starts some amount of time after a ledger opens. From e7841e770f063e3064a4df6655e2771bfe1276ef Mon Sep 17 00:00:00 2001 From: Mark Travis Date: Thu, 12 Oct 2023 17:03:06 -0700 Subject: [PATCH 3/5] Further clarify document. --- src/ripple/app/misc/FeeEscalation.md | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/ripple/app/misc/FeeEscalation.md b/src/ripple/app/misc/FeeEscalation.md index d4e5db41ebe..41ec17ffb02 100644 --- a/src/ripple/app/misc/FeeEscalation.md +++ b/src/ripple/app/misc/FeeEscalation.md @@ -194,16 +194,25 @@ For consensus to be considered healthy, the peers on the network should largely remain in sync with one another. It is particularly important for the validators to remain in sync, because that is required for participation in consensus. However, the network tolerates some -validators being out of sync. Fundamentally, network health is a +validators being out of sync. Fundamentally, network health is a function of validators reaching consensus on sets of recently submitted -transactions. +transactions. + Another factor to consider is the duration of the consensus process itself. This generally takes -under 5 seconds on the main network. This is based on historical -observations. However, some factors, such as transactions volumes, +under 5 seconds on the main network under low volume. This is based on +historical observations. However factors such as transaction volume can increase consensus duration. This is because rippled performs more work as transaction volume increases. Under sufficient load this -tends to increase consensus duration. +tends to increase consensus duration. It's possible that relatively high +consensus duration indicates a problem, but it is not appropriate to +conclude so without investigation. The upper limit for consensus +duration should be roughly 20 seconds. That is far above the normal. +If the network takes this long to close ledgers, then it is almost +certain that there is a problem with the network. This circumstance +often coincides with new ledgers with zero transactions. +A variety of factors contribute to consensus health. + Note that this is not necessarily the duration between ledger closings, as consensus usually starts some amount of time after a ledger opens. From a5e12e04376cf753d06dc784f7d914336f62c5d5 Mon Sep 17 00:00:00 2001 From: Mark Travis Date: Fri, 13 Oct 2023 09:53:00 -0700 Subject: [PATCH 4/5] Remove unnecessary sentence. --- src/ripple/app/misc/FeeEscalation.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/ripple/app/misc/FeeEscalation.md b/src/ripple/app/misc/FeeEscalation.md index 41ec17ffb02..9a533fb9a4f 100644 --- a/src/ripple/app/misc/FeeEscalation.md +++ b/src/ripple/app/misc/FeeEscalation.md @@ -213,10 +213,6 @@ certain that there is a problem with the network. This circumstance often coincides with new ledgers with zero transactions. A variety of factors contribute to consensus health. -Note that this is not necessarily the duration between -ledger closings, as consensus usually starts some amount of time after -a ledger opens. - ### Other Constants * *Base fee transaction limit per ledger*. The minimum value of 5 was From 8d60850c19e62b5718d020508cff99fcaf6bab4c Mon Sep 17 00:00:00 2001 From: Mark Travis Date: Mon, 23 Oct 2023 12:03:55 -0700 Subject: [PATCH 5/5] Review fix, remove isolated sentence. --- src/ripple/app/misc/FeeEscalation.md | 1 - 1 file changed, 1 deletion(-) diff --git a/src/ripple/app/misc/FeeEscalation.md b/src/ripple/app/misc/FeeEscalation.md index 9a533fb9a4f..b86f8dab945 100644 --- a/src/ripple/app/misc/FeeEscalation.md +++ b/src/ripple/app/misc/FeeEscalation.md @@ -211,7 +211,6 @@ duration should be roughly 20 seconds. That is far above the normal. If the network takes this long to close ledgers, then it is almost certain that there is a problem with the network. This circumstance often coincides with new ledgers with zero transactions. -A variety of factors contribute to consensus health. ### Other Constants