Ledger Metrics

[yana-novikova]

Discussion thread for bounty: Ledger Metrics (PR)

(Previous name: Summarize individual ledgers in XRPL Explorer)

This bounty is currently closed.

Details below.

[ckniffen]

@yana-novikova created #21

[intelliot]

Update: This bounty has been approved and is now available for developers to pick up. The original post has been updated with a link to the bounty details. Interested? Discuss by writing a comment below!

[TusharPardhe]

Current design that I am working on:

Some clarifications required:

1. Breakdown of transactions by type (DEX, Payments, Account, NFT, XChain) => Do we need to categorize each tx type like OfferCreate and OfferCancel as DEX txs ? Please elaborate. If yes, do we have a list or we need to manually bifurcate.
2. A special call out (icon) if there are no tecINVARIANT_FAILED transactions => What do you mean by a "call out icon" ?

[TusharPardhe]

Desktop:

Mobile:

First point has been resolved (Header names can be changed)

Resolution of point two A special call out (icon) if there are no tecINVARIANT_FAILED transactions => What do you mean by a "call out icon" ? still pending.

[ckniffen]

The types of transactions should be grouped for example all Offer ones OfferCreate, OfferCancel would be rolled up into one value like DEX. I will work on creating a list. As part of the refactor of transaction types in the explorer will will be adding enums to group transaction types into categories.

The goal of the second milestone was to have the object types show the total number on that ledger. I do not know how to get those values.

[TusharPardhe]

Currently, XRPL "ledger" web socket method (https://xrpl.org/ledger.html#ledger) returns a field named "LedgerEntryType" which comes from this list: https://xrpl.org/ledger-object-types.html

I think this solves it.
PS: We can give them more meaningful UI names, which imo is a better solution. What do you think?

[TusharPardhe]

PR for adding ledger metrics: https://github.com/ripple/explorer/pull/286/files

@yana-novikova @intelliot @ckniffen

[golobitch]

Since there was no change on original PR, I have decided to implement this feature. PR is already open: ripple/explorer#328

@intelliot @ckniffen

I grouped transaction types per category as I saw fit. This can be changed by your specification and it is quite trivial.

[JST5000]

We've accepted both @golobitch and @TusharPardhe's submissions for the 1st milestone of this bounty. We decided to pay both in full for the unique contributions they gave. At this point no further submissions for milestone 1 are being considered.

Milestone 2 is still open though!

[TusharPardhe]

@JST5000 Adding to your point, last time I discussed with @ckniffen for Milestone 2 we need design and a bit of clarity (detailed description) because there will be lots of transaction types.

[JST5000]

Ah, thanks for adding that - we should update here once we have that clarity :)

[golobitch]

1832

[JST5000]

Thanks!

[jonathanlei]

closing this bounty until further decisions are made regarding design and milestone 2.