Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model bug in DiffEntry: Submodules have "blob_url": null and "raw_url": null #623

Closed
flying-sheep opened this issue Apr 3, 2024 · 0 comments · Fixed by #624
Closed

Model bug in DiffEntry: Submodules have "blob_url": null and "raw_url": null #623

flying-sheep opened this issue Apr 3, 2024 · 0 comments · Fixed by #624

Comments

@flying-sheep
Copy link
Contributor

flying-sheep commented Apr 3, 2024

pub blob_url: Url,
pub raw_url: Url,

doesn’t match:

image
2024-04-03T16:36:36.687559Z DEBUG request{method=POST uri=/ version=HTTP/1.1}:HTTP{http.method=GET http.url=https://api.github.com/repos/scverse/scanpy/commits/b1aeff3861e8cbc266189310cb177318c9e56e93 otel.name="HTTP" otel.kind="client"}: octocrab: requesting
2024-04-03T16:36:37.287844Z ERROR request{method=POST uri=/ version=HTTP/1.1}:handle_enqueue: benchmark::server::listener: Enqueue failed: failed to check if commit exists
Caused by:
    0: JSON Error in files[60].blob_url: invalid type: null, expected a string representing an URL at line 1 column 86953

You already fixed that discrepancy between GH docs and reality in models::commits::CommitFile:

pub blob_url: Option<String>,

pub raw_url: Option<String>,

but there are three instances of blob_url in the repo, the third being models::pulls::FileDiff:

pub blob_url: Url,
pub raw_url: Url,

maybe FileDiff, CommitFile, and DiffEntry should be more deduplicated?

@flying-sheep flying-sheep changed the title Model bug in DiffEntry: Submodules have "blob_url": null Model bug in DiffEntry: Submodules have "blob_url": null and "raw_url": null Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant