From 46791e8de367dd9e5ca18d58d8b13eeacab38a71 Mon Sep 17 00:00:00 2001 From: Jakub Skrzynski Date: Fri, 16 Oct 2020 14:11:44 +0200 Subject: [PATCH 1/3] Added straightforward tasks description --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index 264da55..b00872e 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,8 @@ # recruitment-tl-task-public ## Description +Your task is NOT to write code, but to perforrm a code review. + Let's assume you became a leader of the young, immature team, which produces solutions of questionable quality. Below you'll find one of the projects the team is responsible for. Take a look into the repository, do the code review. Point out all the issues with the code quality and how it conforms to clean code (and any other you can think of) principles. Make sure that you look at the code from all possible angles and describe all the possible improvements. Detail all the changes that would have to be done (once again, from all the perspectives you can think of), for this code to become a production ready service (instead of command line application). You could consider resiliency to high loads, things like ddos attacks, auditing etc. ### Task to be reviewed From f28c99ceecb09a887525dcd04da595d47fd656db Mon Sep 17 00:00:00 2001 From: Jakub Skrzynski Date: Fri, 16 Oct 2020 14:14:38 +0200 Subject: [PATCH 2/3] Straightforward task description - typo fix --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b00872e..68b4646 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ # recruitment-tl-task-public ## Description -Your task is NOT to write code, but to perforrm a code review. +Your task is NOT to write code, but to perform a code review. Let's assume you became a leader of the young, immature team, which produces solutions of questionable quality. Below you'll find one of the projects the team is responsible for. Take a look into the repository, do the code review. Point out all the issues with the code quality and how it conforms to clean code (and any other you can think of) principles. Make sure that you look at the code from all possible angles and describe all the possible improvements. Detail all the changes that would have to be done (once again, from all the perspectives you can think of), for this code to become a production ready service (instead of command line application). You could consider resiliency to high loads, things like ddos attacks, auditing etc. From 9c0cde8fda566ad247f2fad18dd825f4d756ecfa Mon Sep 17 00:00:00 2001 From: Jakub Skrzynski Date: Fri, 16 Oct 2020 14:51:17 +0200 Subject: [PATCH 3/3] Straightforward task description - capital plus bold --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 68b4646..957b40a 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,8 @@ # recruitment-tl-task-public ## Description -Your task is NOT to write code, but to perform a code review. + +**YOUR TASK IS NOT TO WRITE CODE, BUT TO PERFORM A CODE REVIEW.** Let's assume you became a leader of the young, immature team, which produces solutions of questionable quality. Below you'll find one of the projects the team is responsible for. Take a look into the repository, do the code review. Point out all the issues with the code quality and how it conforms to clean code (and any other you can think of) principles. Make sure that you look at the code from all possible angles and describe all the possible improvements. Detail all the changes that would have to be done (once again, from all the perspectives you can think of), for this code to become a production ready service (instead of command line application). You could consider resiliency to high loads, things like ddos attacks, auditing etc.