From 36079b27dc23d29c1e53c353eb09fc6aaba068d0 Mon Sep 17 00:00:00 2001 From: Ian Dunn Date: Fri, 31 Mar 2023 16:23:47 -0700 Subject: [PATCH] clean up - no behavior changes --- .../postcss/header/header.pcss | 43 +++++-------------- 1 file changed, 10 insertions(+), 33 deletions(-) diff --git a/mu-plugins/blocks/global-header-footer/postcss/header/header.pcss b/mu-plugins/blocks/global-header-footer/postcss/header/header.pcss index 96f2af833..74d860d9b 100644 --- a/mu-plugins/blocks/global-header-footer/postcss/header/header.pcss +++ b/mu-plugins/blocks/global-header-footer/postcss/header/header.pcss @@ -15,57 +15,34 @@ html { * @link https://github.com/WordPress/wporg-mu-plugins/issues/371. */ html.has-modal-open { - /* Override https://github.com/WordPress/gutenberg/pull/49369/ on other non-mobile breakpoints to avoid gap on right side of search modal. */ + /* + * Hotfix for https://github.com/WordPress/gutenberg/pull/49369/. Otherwise the styles below will break when + * we update. Remove this after we install the update + */ + position: fixed; + + /* + * Override https://github.com/WordPress/gutenberg/pull/49369/. On desktop views it causes a gap to the right + * of the search modal when it's open. + */ position: static; @media (--mobile-only) { - /*position: fixed;*/ /* hotfix for https://github.com/WordPress/gutenberg/pull/49369/. remove when in stable release. */ - /* if leave ^ enabled, then there's a gap at the bottom of the page where
shows through - if disable, then safari scroll a little, but it's not visible above the fold - */ - height: 100lvh; - overflow: hidden; - /* todo - maybe set bg color grey to override - try dvh height - try setting height less than 100vh - - add fixed to header in case that helps - */ - - & body{ - /* - none necessary - position: fixed; - height: 100vh; - overflow: hidden;*/ - - background: var(--wp--preset--color--charcoal-1); - } & body:not(.admin-bar) { background: var(--wp--preset--color--charcoal-5); } - & .wp-site-blocks { - /* all of this necessary */ position: fixed; height: 100vh; overflow: hidden; } & .wp-block-navigation__responsive-container { - /* need to disable overflow vis from search.pcss? */ - height: 100vh; - - /* - these not necessary - position: fixed; - overflow: hidden;*/ } & #wpadminbar {