From 6a0678659792ede933dbacb3b75c34e93a967a30 Mon Sep 17 00:00:00 2001 From: Jonny Harris Date: Tue, 26 Sep 2023 12:26:38 +0000 Subject: [PATCH] Editor: Fix deprecation notice in block editor. In [56682], the `print_emoji_styles` function was deprecated and a corresponding deprecation notice was added. In order to maintain backward compatibility, `print_emoji_styles` was retained as a hook into wp_print_styles. This resulted in the appearance of deprecation notices within the block editor. The root of this issue was the manual invocation of the `wp_print_styles` function in block-editor.php. To address this, the `print_emoji_styles` callback was manually removed, `wp_print_styles` was called, and the action was subsequently rehooked, resolving the deprecation notice within the block editor. Props mamaduka, hellofromtonya, spacedmonkey. See #58775. git-svn-id: https://develop.svn.wordpress.org/trunk@56706 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/block-editor.php | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/wp-includes/block-editor.php b/src/wp-includes/block-editor.php index ba92c0ec3f2b7..7b63490a8a261 100644 --- a/src/wp-includes/block-editor.php +++ b/src/wp-includes/block-editor.php @@ -359,11 +359,24 @@ function _wp_get_iframed_editor_assets() { } } + /** + * Remove the deprecated `print_emoji_styles` handler. + * It avoids breaking style generation with a deprecation message. + */ + $has_emoji_styles = has_action( 'wp_print_styles', 'print_emoji_styles' ); + if ( $has_emoji_styles ) { + remove_action( 'wp_print_styles', 'print_emoji_styles' ); + } + ob_start(); wp_print_styles(); wp_print_font_faces(); $styles = ob_get_clean(); + if ( $has_emoji_styles ) { + add_action( 'wp_print_styles', 'print_emoji_styles' ); + } + ob_start(); wp_print_head_scripts(); wp_print_footer_scripts();