Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Document design tokens #34

Closed
melchoyce opened this issue Aug 24, 2023 · 5 comments
Closed

Document design tokens #34

melchoyce opened this issue Aug 24, 2023 · 5 comments

Comments

@melchoyce
Copy link
Contributor

In creating my first pattern from the Figma file, I encountered some decisions I wasn't sure how to approach:

  • Font sizes in Figma that aren't in theme.json
  • Default spacing units

We should document some of these tokens and how to use them when creating patterns.

@luminuu
Copy link
Member

luminuu commented Aug 24, 2023

Another one:

  • Fonts

@richtabor
Copy link
Member

richtabor commented Aug 28, 2023

Default spacing units

Proposal here for fluid spacing: #102.

I'm thinking the 40 preset to be used as the standard padding around edges.

@colorful-tones
Copy link
Member

colorful-tones commented Sep 5, 2023

It is currently quite challenging to try and build a pattern. We should try to streamline some of these tokens and make them readily available. I recommend we update the variables in the Figma file and make some docs (markdown table in README at the very least) for contributors to grab and reference key tokens. I'm happy to help and will be at tomorrow's meeting. 😄

@richtabor
Copy link
Member

I recommend we update the variables in the Figma file.

I've done that. What kind of table do you think we need? I think as long as you're using a spacing, color, font size preset, then you're sitting good.

@colorful-tones
Copy link
Member

I think #213 was a step in the right direction, but we'll have to be mindful of keeping it up to date if anything changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants