Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics search event fires when exising search term is repeated #4708

Open
zackkrida opened this issue Aug 2, 2024 · 0 comments
Open

Analytics search event fires when exising search term is repeated #4708

zackkrida opened this issue Aug 2, 2024 · 0 comments
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend

Comments

@zackkrida
Copy link
Member

Description

Our analytics event for submitting a search fires on the /search route even when the search term is "cleared" by selecting the text in the input, deleting it, and pressing enter or the search button.

Reproduction

  1. Visit https://openverse.org/ and submit a search
  2. Open the developer tools of your preferred browser to the Network tavb
  3. Clear the search bar, and without unfocusing the search bar, submit a search.
  4. See that the event was sent.

In writing this, I remembered that it is technically impossible to clear the search bar, so this issue really happens when resubmitting the current search term, not when clearing.

@zackkrida zackkrida added 🟩 priority: low Low priority and doesn't need to be rushed 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: frontend Related to the Nuxt frontend labels Aug 2, 2024
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant