Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockCanvas: Make contentRef property stable #67210

Closed
wants to merge 1 commit into from
Closed

BlockCanvas: Make contentRef property stable #67210

wants to merge 1 commit into from

Conversation

costasovo
Copy link
Contributor

What?

This PR makes BlockCanvas's contentRef property stable.

Why?

It is used by a couple of custom build block editors. Please see more details in #67209

Fixes #67209

@costasovo costasovo requested a review from ellatrix as a code owner November 21, 2024 16:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: costasovo <costasovo@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@costasovo costasovo mentioned this pull request Nov 21, 2024
Closed
@Mamaduka
Copy link
Member

Thanks for contributing, @costasovo!

It looks like the linked issue has been closed. Can we also close this PR?

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Package] Block editor /packages/block-editor [Status] Blocked Used to indicate that a current effort isn't able to move forward labels Jan 13, 2025
@costasovo
Copy link
Contributor Author

@Mamaduka Sure! I forgot to close it. Thank you for the ping! Closing now.

@costasovo costasovo closed this Jan 14, 2025
@Mamaduka
Copy link
Member

Thank you, @costasovo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

Assignees
No one assigned
Labels
[Package] Block editor /packages/block-editor [Status] Blocked Used to indicate that a current effort isn't able to move forward [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stabilize BlockCanvas's contentRef property
2 participants
@costasovo @Mamaduka