From 0c1dbfa72fbea7d133d0ae5391ae7478784a27e6 Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers Date: Wed, 20 Nov 2024 09:51:37 -0500 Subject: [PATCH 1/2] Add a note about required Core SVN changes. --- docs/explanations/architecture/performance.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/explanations/architecture/performance.md b/docs/explanations/architecture/performance.md index 4c8b6386b9263b..c1ee4a1531ed81 100644 --- a/docs/explanations/architecture/performance.md +++ b/docs/explanations/architecture/performance.md @@ -84,6 +84,12 @@ The new reference commit hash that is chosen needs to meet the following require - Be compatible with the new WP version used in the "Tested up to" flag. - Is already tracked on "codevitals.run" for all existing metrics. +Before releasing a version of the plugin with changes to the WordPress minimum requirements, the end-to-end test GitHub Action workflow in Core SVN will need to be updated for any branch losing support. Otherwise the next run of that workflow on that branch will fail. + +The version of the plugin can be pinned by adding the `gutenberg-version` input to the test matrix. [Core-59221](https://core.trac.wordpress.org/changeset/59221) is an example of this change for the 6.4 branch. + +**Note:** Always use the final release including bug fixes (ie. `x.y.2` or `x.y.3`). + **A simple way to choose commit is to pick a very recent commit on trunk with a passing performance job.** ## Going further From da379c732d09c8544b3ab009999165b4a867dd69 Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers <359867+desrosj@users.noreply.github.com> Date: Wed, 20 Nov 2024 11:50:58 -0500 Subject: [PATCH 2/2] A few refinements. --- docs/explanations/architecture/performance.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/explanations/architecture/performance.md b/docs/explanations/architecture/performance.md index c1ee4a1531ed81..8c1034ad9de331 100644 --- a/docs/explanations/architecture/performance.md +++ b/docs/explanations/architecture/performance.md @@ -84,11 +84,11 @@ The new reference commit hash that is chosen needs to meet the following require - Be compatible with the new WP version used in the "Tested up to" flag. - Is already tracked on "codevitals.run" for all existing metrics. -Before releasing a version of the plugin with changes to the WordPress minimum requirements, the end-to-end test GitHub Action workflow in Core SVN will need to be updated for any branch losing support. Otherwise the next run of that workflow on that branch will fail. +When releasing a plugin update with changes to the minimum WordPress version requirements, the end-to-end test GitHub Action workflow in Core SVN will need to be updated for any branch losing support. Otherwise the first run of that workflow on that branch following the release will fail. -The version of the plugin can be pinned by adding the `gutenberg-version` input to the test matrix. [Core-59221](https://core.trac.wordpress.org/changeset/59221) is an example of this change for the 6.4 branch. +The version of the plugin used in the workflow can be pinned by adding the `gutenberg-version` input to the test matrix. [Core-59221](https://core.trac.wordpress.org/changeset/59221) is an example of this change for the 6.4 branch. -**Note:** Always use the final release including bug fixes (ie. `x.y.2` or `x.y.3`). +**Note:** Always use the final release including bug fixes (ie. `x.y.2` or `x.y.3`). If the final release is not yet known, create a [Trac ticket](https://core.trac.wordpress.org/ticket/62488) so it's not forgotten. **A simple way to choose commit is to pick a very recent commit on trunk with a passing performance job.**