From e0d6636b6e34f1519fb8ccf17fda62adb5342cf5 Mon Sep 17 00:00:00 2001 From: CreativeDive <31563167+CreativeDive@users.noreply.github.com> Date: Mon, 7 Oct 2019 13:01:20 +0200 Subject: [PATCH 1/4] Update style.scss Left aligned blocks should not inherited "float:left" to nested blocks. In reference to #17793 --- packages/block-editor/src/components/block-list/style.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-editor/src/components/block-list/style.scss b/packages/block-editor/src/components/block-list/style.scss index e59b6ddc34337..761632c49d7c7 100644 --- a/packages/block-editor/src/components/block-list/style.scss +++ b/packages/block-editor/src/components/block-list/style.scss @@ -448,7 +448,7 @@ // Left &[data-align="left"] { // This is in the editor only; the image should be floated on the frontend. - .block-editor-block-list__block-edit { + > .block-editor-block-list__block-edit { /*!rtl:begin:ignore*/ float: left; margin-right: 2em; From 4e84614141fa64a2e99d264ff8fb3d2ca135c04a Mon Sep 17 00:00:00 2001 From: Martin Jost <31563167+CreativeDive@users.noreply.github.com> Date: Wed, 6 Nov 2019 20:37:38 +0100 Subject: [PATCH 2/4] Fix visually hidden image for content column Media/Text block bug with nested Image block: Image is not visible #18296 --- packages/block-library/src/media-text/style.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/block-library/src/media-text/style.scss b/packages/block-library/src/media-text/style.scss index c8dc4f8ac2b73..9c42830c63272 100644 --- a/packages/block-library/src/media-text/style.scss +++ b/packages/block-library/src/media-text/style.scss @@ -41,13 +41,13 @@ vertical-align: middle; } -.wp-block-media-text.is-image-fill figure { +.wp-block-media-text.is-image-fill figure.wp-block-media-text__media { height: 100%; min-height: 250px; background-size: cover; } -.wp-block-media-text.is-image-fill figure > img { +.wp-block-media-text.is-image-fill figure.wp-block-media-text__media > img { // The image is visually hidden but accessible to assistive technologies. position: absolute; width: 1px; From 63f553cb959dd608a1554f67287d1544206d33f3 Mon Sep 17 00:00:00 2001 From: Martin Jost <31563167+CreativeDive@users.noreply.github.com> Date: Wed, 6 Nov 2019 20:47:31 +0100 Subject: [PATCH 3/4] Fix hidden nested images in content column Media/Text block bug with nested Image block: Image is not visible #18296 From add8ff13ef3fbb0e9ee14854f1d602b9928e5e94 Mon Sep 17 00:00:00 2001 From: Martin Jost <31563167+CreativeDive@users.noreply.github.com> Date: Tue, 12 Nov 2019 13:42:35 +0100 Subject: [PATCH 4/4] Update packages/block-editor/src/components/block-list/style.scss Co-Authored-By: Riad Benguella --- packages/block-editor/src/components/block-list/style.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-editor/src/components/block-list/style.scss b/packages/block-editor/src/components/block-list/style.scss index 761632c49d7c7..e59b6ddc34337 100644 --- a/packages/block-editor/src/components/block-list/style.scss +++ b/packages/block-editor/src/components/block-list/style.scss @@ -448,7 +448,7 @@ // Left &[data-align="left"] { // This is in the editor only; the image should be floated on the frontend. - > .block-editor-block-list__block-edit { + .block-editor-block-list__block-edit { /*!rtl:begin:ignore*/ float: left; margin-right: 2em;