-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editing a gallery shows all images from the media library as selected #9072
Comments
Good find! Tested and confirmed with WordPress 4.9.8 and Gutenberg 3.6.2 using Firefox 61.0.2 and Chrome 68.0.3440.106 on macOS 10.13.6. (1m29s) |
This is still happening today. I was able to reproduce this just now. 👍 |
Just yesterday I was also able to reproduce the same issue. Btw I received some feedback in the Slack #design channel: https://www.useloom.com/share/71a4e0dc1f064f5f92392a28ca23610c |
Btw - An update for GB version 5.0 Rc-1 Uploading media: Still having the same gallery block selected click the pencil icon. All the images in the media library shows up. I clicked cancel. Deselected the gallery block and then selected it again. Then only 4 images showed up in the Edit Gallery view. |
I started digging into this. Wanted to document some of my initial findings as I find a solution. gutenberg/packages/block-library/src/gallery/edit.js Lines 198 to 216 in d9b232d
The images object updates as each photo dropped is uploaded. I'm thinking that the initial |
this is invalid now as that button has been removed; |
Describe the bug
After creating a gallery block and uploading an image to it – via drag & drop or the upload button – all images of the media library are displayed as selected in the edit gallery view. I am using Gutenberg 3.5.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Just the images from the gallery should be set as selected.
Screenshots
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: