Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid to move focus programmatically: Inserter menu and everywhere #685

Closed
afercia opened this issue May 5, 2017 · 1 comment
Closed
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented May 5, 2017

Splitting this out from #578

For accessibility, moving focus programmatically should be done in very rare cases, for example when there's a single, very specific task to accomplish or in a modal, etc.

It should never be done in cases where moving focus will skip relevant content, as keyboard users would be forced to tab backwards to get to the skipped content and screen reader users won't even have a clue there is some content "before" the current focus.

In regard to the inserter menu, focus shouldn't be moved to the search field.

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label May 5, 2017
@mtias
Copy link
Member

mtias commented Aug 31, 2017

Closing this as the inserter has been modified a few times and is no longer problematic on this specific behaviour.

@mtias mtias closed this as completed Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

2 participants