Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors on link input #680

Closed
ellatrix opened this issue May 5, 2017 · 3 comments
Closed

Errors on link input #680

ellatrix opened this issue May 5, 2017 · 3 comments
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended

Comments

@ellatrix
Copy link
Member

ellatrix commented May 5, 2017

Warning: value prop on input should not be null. Consider using the empty string to clear the component or undefined for uncontrolled components.
in input (created by FormatToolbar)

Warning: A component is changing an uncontrolled input of type url to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa). Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://fb.me/react-controlled-components
in input (created by FormatToolbar)

@jasmussen jasmussen added this to the Beta milestone May 10, 2017
@jasmussen jasmussen added the [Type] Bug An existing feature does not function as intended label May 16, 2017
@aduth aduth added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label May 26, 2017
@mkaz
Copy link
Member

mkaz commented Jun 12, 2017

I don't see this error - not sure if it was fixed at some point and just not closed.

It looks like this line does set a default value of empty string, however this was in place prior to this issue being opened, so seems unlikely.
https://github.com/WordPress/gutenberg/blob/master/blocks/editable/format-toolbar.js#L31

@iseulde If you can still reproduce, can you include some more info such as browser, and steps to reproduce. I'm going to look at another Link bug as part of beta milestone so will keep an eye out for it also

@mtias mtias modified the milestones: Beta 2, Beta Jun 15, 2017
@ellatrix
Copy link
Member Author

Can definitely still reproduce. Put the caret in a word and click the link button. Genning the error mentioned above.

@ellatrix
Copy link
Member Author

Fixed in 00c9bbe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants