Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brackets are being read as a shortcode #6250

Closed
karmatosed opened this issue Apr 18, 2018 · 8 comments
Closed

Brackets are being read as a shortcode #6250

karmatosed opened this issue Apr 18, 2018 · 8 comments
Labels
[Type] Bug An existing feature does not function as intended
Milestone

Comments

@karmatosed
Copy link
Member

This is an interesting note, when you use [ brackets ] in something you aren't always signifying a shortcode. Gutenberg gets a little keen when it sees this. Is there anything we can do to ease this?

@karmatosed karmatosed added the [Type] Enhancement A suggestion for improvement. label Apr 18, 2018
@karmatosed
Copy link
Member Author

Closing as see #3806 has this covered.

@ellatrix
Copy link
Member

@karmatosed I don't think this is the same issue?

@ellatrix
Copy link
Member

Reopening. I think the best thing to do here is get all registered short codes and match any of those instead of anything in between brackets.

@ellatrix ellatrix reopened this Apr 19, 2018
@karmatosed
Copy link
Member Author

Ah thanks for clarification @iseulde

@karmatosed karmatosed added this to the Merge Proposal: Editor milestone Apr 27, 2018
@karmatosed karmatosed added [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels Apr 27, 2018
@tofumatt
Copy link
Member

tofumatt commented May 8, 2018

Just to be clear, it seems the issue is that, for instance, text containing [bracket] that isn't already a Gutenberg block (no wp: comments around it), will show the classic editor and then when converted to a block change into a shortcode block even though no valid shortcode for that exists, right? I can reproduce that but I wasn't quite clear if that's what this issue is describing.

If I type [brackets] into an empty new block, an existing block, etc. I don't see Gutenberg try to change it to a shortcode...

@ellatrix
Copy link
Member

See also #5695. I think we might have fixed the worst part with #6329. What is currently broken here?

@mtias
Copy link
Member

mtias commented Jun 22, 2018

@karmatosed anything pending here?

@karmatosed
Copy link
Member Author

I can't replicate in latest version so lets close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants