Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"&hellip" visible in the "Publish" button #5939

Closed
zacharyhickson opened this issue Apr 3, 2018 · 8 comments
Closed

"&hellip" visible in the "Publish" button #5939

zacharyhickson opened this issue Apr 3, 2018 · 8 comments
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Status] Needs More Info Follow-up required in order to be actionable. [Type] Bug An existing feature does not function as intended

Comments

@zacharyhickson
Copy link

Issue Overview

"…" text is being printed in the Publish button.

Steps to Reproduce (for bugs)

  1. Brand new installation of WordPress on a local MAMP Pro setup.
  2. WordPress Version: 4.9.4 (English Australia localisation)
  3. Gutenberg Version: 2.5.0
  4. No other active plugins

OS: macOS High Sierra 10.13.3
Browser: Google Chrome - Version 65.0.3325.181 (Official Build) (64-bit)
Tested in both Normal and Incognito modes.

Expected Behavior

The "…" should not be outputted as text, but converted to HTML.

Screenshots / Video

screen shot 2018-04-03 at 12 08 19 pm

screen shot 2018-04-03 at 12 34 46 pm

@ZebulanStanphill
Copy link
Member

Possibly related since they both involve HTML entity parsing: #5717

@felipeelia
Copy link
Member

Actually this seems to be a problem with the current translation of the string, as seen in GlotPress.
GlotDict displays this warning:
Warning: The translation contains a final ... that should be translated as …
But in this case I think it should be translated just as is.

@danielbachhuber
Copy link
Member

@felipeelia Sorry, I'm not sure I follow. Do you have a suggested resolution for this issue?

@danielbachhuber danielbachhuber added [Type] Bug An existing feature does not function as intended [Status] Needs More Info Follow-up required in order to be actionable. Internationalization (i18n) Issues or PRs related to internationalization efforts labels Apr 10, 2018
@felipeelia
Copy link
Member

I think @zacharyhickson can already confirm if it's all right now, @danielbachhuber.
I've sent the correct string to GlotPress and @ntwb has already accepted it (thanks btw).

The problem seems to be in GlotPress or GlotDict, suggesting to translate strings containg ... with …, when it's not always the case.

@zacharyhickson
Copy link
Author

Thanks @felipeelia. FYI I've also updated to Gutenberg 2.6.

Seems like the bug is still there though.

What can you do, I guess us Aussies still have a weird language ;)

Do I need to use a different (development) version of Gutenberg to test this?

@ntwb
Copy link
Member

ntwb commented Apr 11, 2018

I suspect this is due to the generation of strings for Gutenberg in using json_encode() in /lib/parser.php, see WP#32875:Comment#6 for further details on this.

@felipeelia
Copy link
Member

Did you update the translations as well, @zacharyhickson?

I'll give a look into that @ntwb. Thanks for dropping by.

@jorgefilipecosta
Copy link
Member

The merge of #6114 should have resolved the issue in the publish button. We should have used 'Publish…' ( … is a special char) instead of 'Publish...' (... three points) like we do in the other places.
As the main issue is solved I will close this issue. Thank you for the debugging I think It was useful and we may have some other problems where characters may be wrongly "translated".
Of course, if the issue persists in your tests feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Status] Needs More Info Follow-up required in order to be actionable. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

6 participants