Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize widgets: Undo and Redo buttons are disabled thus breaking expected keyboard interaction #57678

Open
afercia opened this issue Jan 9, 2024 · 0 comments
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jan 9, 2024

Description

See #57647

I'm not sure what the plans are for the customize-widgets package so I'm not sure it is worth fixing it. However, the NavigableToolbar with Undo and Redo buttons suffers from the same bugs reported in #57647.

  • The buttons used disabled while they should use aria-disabled instead.
  • As such, arrows key navigation doesn't work when these buttons are disabled.
  • Focus style is not visible.

Screenshot:

Screenshot 2024-01-09 at 14 51 20

Step-by-step reproduction instructions

Basically, repeat the steps from #57647 but test the Customizer instead.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. labels Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant