Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users can scroll off the bottom of the block editor into a forbidden void when searching in the inserter #56811

Closed
talldan opened this issue Dec 6, 2023 · 5 comments · Fixed by #57127
Assignees
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Testing Needs further testing to be confirmed. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Dec 6, 2023

Step-by-step reproduction instructions

  1. Open the site editor (not sure if it happens in the post editor)
  2. Open the inserter
  3. Enter the search term 'List'

Expected: The inserter scrollbar expands, but the canvas scroll bar isn't affected
Actual: The canvas scrollbar expands allowing users to scroll down into empty space

Screenshots, screen recording, code snippet

Kapture.2023-12-06.at.13.16.11.mp4

Environment info

Tested against latest Gutenberg trunk (d1d0b2a)
Mac OS / Brave

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@talldan talldan added [Type] Bug An existing feature does not function as intended [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels Dec 6, 2023
@colorful-tones
Copy link
Member

Confirmed in Chrome Version 120.0.6099.109 with latest Gutenberg trunk 9879b85

@colorful-tones
Copy link
Member

Also, this happens in the post editor as well. It is not isolated to the Site Editor.

@colorful-tones
Copy link
Member

This is definitely browser based and bug exists in Safari Version 17.2 (19617.1.17.11.9) too, but does not affect Firefox 120. I'm doing some debugging to try and decipher what has changed in Blink/webkit browsers, while accounting to make sure all will work nicely on mobile (iOS). I think I've traced it down to an overflow issue. There is this note from Safari 17.2 Release Notes, which feels like a solid lead: https://developer.apple.com/documentation/safari-release-notes/safari-17_2-release-notes#Scrolling.

I'm feeling like it is pointing to styling here: https://github.com/WordPress/gutenberg/blob/trunk/packages/interface/src/components/interface-skeleton/style.scss#L45-L137

@colorful-tones
Copy link
Member

I think I've got a fix in place #57127, but it could use some thorough cross browser testing. I only had time to fix and verify in Chrome 120.

@colorful-tones colorful-tones self-assigned this Dec 15, 2023
@colorful-tones colorful-tones moved this from 📥 Todo to 🏗️ In Progress in WordPress 6.5 Editor Tasks Dec 15, 2023
@colorful-tones colorful-tones added Browser Issues Issues or PRs that are related to browser specific problems [Status] In Progress Tracking issues with work in progress Needs Testing Needs further testing to be confirmed. labels Dec 15, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in WordPress 6.5 Editor Tasks Dec 20, 2023
@andrewserong
Copy link
Contributor

Thanks for fixing this one up @colorful-tones! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Testing Needs further testing to be confirmed. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants