-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing verb in string? #54872
Comments
It has a translation comment:
I think we're making it more complicated. There are two full translation strings; leave only the new block name as a variable. Source: gutenberg/packages/block-editor/src/hooks/block-rename-ui.js Lines 49 to 54 in 937d51e
|
Or just add "is" before the first variable... that would make it even more clear... but then again, conjugation of verbs is a thing. |
I was thinking of having two strings cc @getdave |
Perfect. That would sidestep the issue with conjugation of verbs as well |
That sounds good to me. Thank you both 👍 |
Thanks for the confirmation, @getdave! I'll create PR tomorrow. I need to head out now. |
Description
During translation I noticed this string: https://translate.wordpress.org/projects/wp-plugins/gutenberg/dev/nl-be/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=16400696&sort%5Bby%5D=translation_date_added&sort%5Bhow%5D=asc&historypage
https://plugins.trac.wordpress.org/browser/gutenberg/trunk/build/block-editor/index.js#L44010
Block name %1$s to: "%2$s".
Is it me or is there a verb missing here?
Step-by-step reproduction instructions
N/A
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: