Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing verb in string? #54872

Closed
NekoJonez opened this issue Sep 27, 2023 · 6 comments · Fixed by #54887
Closed

Missing verb in string? #54872

NekoJonez opened this issue Sep 27, 2023 · 6 comments · Fixed by #54887
Assignees
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@NekoJonez
Copy link
Contributor

Description

During translation I noticed this string: https://translate.wordpress.org/projects/wp-plugins/gutenberg/dev/nl-be/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=16400696&sort%5Bby%5D=translation_date_added&sort%5Bhow%5D=asc&historypage

https://plugins.trac.wordpress.org/browser/gutenberg/trunk/build/block-editor/index.js#L44010

Block name %1$s to: "%2$s".

Is it me or is there a verb missing here?

Step-by-step reproduction instructions

N/A

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Mamaduka Mamaduka added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Sep 27, 2023
@Mamaduka
Copy link
Member

It has a translation comment:

translators: %1$s: type of update (either reset or changed). %2$s: new name/label for the block

I think we're making it more complicated. There are two full translation strings; leave only the new block name as a variable.

Source:

sprintf(
/* translators: %1$s: type of update (either reset of changed). %2$s: new name/label for the block */
__( 'Block name %1$s to: "%2$s".' ),
nameIsOriginal || nameIsEmpty ? __( 'reset' ) : __( 'changed' ),
editedBlockName
),

@NekoJonez
Copy link
Contributor Author

Or just add "is" before the first variable... that would make it even more clear... but then again, conjugation of verbs is a thing.

@Mamaduka
Copy link
Member

I was thinking of having two strings Block name reset to: "%s". and Block name changed to: "%s"..

cc @getdave

@NekoJonez
Copy link
Contributor Author

Perfect. That would sidestep the issue with conjugation of verbs as well

@getdave
Copy link
Contributor

getdave commented Sep 27, 2023

That sounds good to me. Thank you both 👍

@Mamaduka
Copy link
Member

Thanks for the confirmation, @getdave!

I'll create PR tomorrow. I need to head out now.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 27, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants