You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Because of the above defined margins, consumers who use the Notice component have to specify their own margins to override this, which is an inconvenient developer experience.
This issue can also be seen in the Gutenberg editor, where the Notice component's margin is being overridden with 0:
It would be better to have no margins. The spacing of the Notice component should be controlled by the parent layout component.
As an example, we can refer to Ant Design's Alert component. The component does not have any margins. Spacing between multiple Notice components are controlled by the parent layout component.
What is your proposed solution?
Remove the margins from the Notice component.
The text was updated successfully, but these errors were encountered:
What problem does this address?
Currently the Notice component has margins being defined in its CSS:
gutenberg/packages/components/src/notice/style.scss
Line 7 in 0c0d013
Because of the above defined margins, consumers who use the Notice component have to specify their own margins to override this, which is an inconvenient developer experience.
Here's a screenshot from https://wordpress.github.io/gutenberg/?path=/story/components-notice--notice-list-subcomponent - we can see that the Notices are not left-aligned with the checkbox because they have a 15px left margin:
This issue can also be seen in the Gutenberg editor, where the Notice component's margin is being overridden with 0:
It would be better to have no margins. The spacing of the Notice component should be controlled by the parent layout component.
As an example, we can refer to Ant Design's Alert component. The component does not have any margins. Spacing between multiple Notice components are controlled by the parent layout component.
What is your proposed solution?
Remove the margins from the Notice component.
The text was updated successfully, but these errors were encountered: