Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: editing a page and setting a password: users can't see the password they are entering #52607

Closed
afercia opened this issue Jul 13, 2023 · 4 comments · Fixed by #52622
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jul 13, 2023

Description

Please see this comment: #52605 (comment)

Not sure showing asterisks while users are entering the password they want to use to protect a page is a good UI / User experience.

Unless I'm missing something, seems to me this should be fixed for WP 6.3 as it's a less than ideal UI to release to the public.

Cc @annezazu @tellthemachines for some kind help with triaging ❤️

Step-by-step reproduction instructions

  • Edit a page in the Site editor.
  • Try to set a password to protect the page.
  • Observe that all you can see while entering your password is a nice series of asterisks.

Screenshots, screen recording, code snippet

asterisks

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Site /packages/edit-site labels Jul 13, 2023
@tellthemachines
Copy link
Contributor

Thanks @afercia ! Added to the 6.3 board.

@tellthemachines
Copy link
Contributor

I think the problem is we're using an input of type password when we should be using text.

@afercia
Copy link
Contributor Author

afercia commented Jul 14, 2023

I think the problem is we're using an input of type password when we should be using text.

Yes, that is what I said in the comment linked at the beginning of this issue description:

Please see this comment: #52605 (comment)

Thanks for the quick triaging and fix ❤️

@annezazu
Copy link
Contributor

Thank you for reporting and the quick fix, folks!

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants