Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Color Randomizer from 6.3 #52296

Closed
annezazu opened this issue Jul 4, 2023 · 3 comments · Fixed by #52306
Closed

Remove Color Randomizer from 6.3 #52296

annezazu opened this issue Jul 4, 2023 · 3 comments · Fixed by #52306
Assignees
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

annezazu commented Jul 4, 2023

In testing 6.3 beta 3, I noticed that the "randomize colors" was listed as an option in Styles. This is an experimental option for Gutenberg and, unless something changed, should not be in 6.3:

Screen Shot 2023-07-04 at 4 24 48 PM

Furthermore, I can still see it listed as an unworkable button in GB 16.1.1 so something must have gone wrong here. Here are the related PRs for this feature in case it helps: #40988 #51539

Here's a video of the current experience:

remove.color.randomizer.mov

cc @tellthemachines @ramonjd as Core Editor tech leads!

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jul 4, 2023
@annezazu annezazu changed the title Remove Style Randomizer from 6.3 Remove Color Randomizer from 6.3 Jul 4, 2023
@ramonjd
Copy link
Member

ramonjd commented Jul 5, 2023

Just checking the branches. Here's what I'm seeing:

Gutenberg wp/6.3

Screenshot 2023-07-05 at 12 40 15 pm

Gutenberg trunk

Screenshot 2023-07-05 at 12 40 58 pm

Core trunk (6.3-beta3-56130-sr)

Screenshot 2023-07-05 at 12 43 11 pm

Very curious... it appears it should only kick in when window.__experimentalEnableColorRandomizer is set to true

window.__experimentalEnableColorRandomizer doesn't appear in the global context in Core trunk 🤔

I'll have a dig around

@tellthemachines
Copy link
Contributor

Looks like we need to add back the randomizeThemeColors check that was removed here

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 5, 2023
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.3.x Editor Tasks Jul 5, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 5, 2023
@annezazu
Copy link
Contributor Author

annezazu commented Jul 5, 2023

Amazing sleuthing. Thank you for the quick work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants