Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks inserted with the Side Inserter don't increment the usage count #5207

Closed
pento opened this issue Feb 23, 2018 · 0 comments · Fixed by #5261
Closed

Blocks inserted with the Side Inserter don't increment the usage count #5207

pento opened this issue Feb 23, 2018 · 0 comments · Fixed by #5261
Assignees
Labels
[Type] Bug An existing feature does not function as intended

Comments

@pento
Copy link
Member

pento commented Feb 23, 2018

Issue Overview

#4953 added the side inserter with frequent block shortcuts, which is super cool.

Unfortunately, adding blocks using this new functionality doesn't increment the relevant counter in state.preferences.insertUsage, so the frequent block shortcuts don't change.

Steps to Reproduce

  1. Open a new post.
  2. Click in the default paragraph.
  3. Observer the state of state.preferences.insertUsage.
  4. Click a frequently used block, or a block from the inserter.

Expected Behaviour

The state.preferences.insertUsage counter should increment for the block that you just switched to, so that the frequently used blocks list rearranges itself correctly.

@pento pento added the [Type] Bug An existing feature does not function as intended label Feb 23, 2018
@youknowriad youknowriad self-assigned this Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants