Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position of block error messages #5201

Closed
Soean opened this issue Feb 22, 2018 · 2 comments
Closed

Position of block error messages #5201

Soean opened this issue Feb 22, 2018 · 2 comments
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.

Comments

@Soean
Copy link
Member

Soean commented Feb 22, 2018

Issue Overview

If a very long block shows an error, its hard to understand and to find it, because it is in the middle of the block. So you have to scroll a lot to see that there is an error.

Possible Solution

  • Show the error message at the top of the Block
  • The error message scrolls within the block

Screenshots / Video

error_test

@Soean Soean added the Needs Design Feedback Needs general design feedback. label Feb 22, 2018
@karmatosed
Copy link
Member

I think I would agree we should just show at the top and maybe not even render the full block in this case, if we can do that.

@karmatosed karmatosed added [Feature] Blocks Overall functionality of blocks and removed Needs Design Feedback Needs general design feedback. labels Feb 23, 2018
@nshki nshki mentioned this issue Mar 4, 2018
3 tasks
@mtias mtias added the [Type] Enhancement A suggestion for improvement. label Mar 6, 2018
@Soean
Copy link
Member Author

Soean commented May 16, 2018

Was fixed in #5383

@Soean Soean closed this as completed May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants