Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless animation when interacting with page list block #49039

Open
draganescu opened this issue Mar 13, 2023 · 2 comments
Open

Useless animation when interacting with page list block #49039

draganescu opened this issue Mar 13, 2023 · 2 comments
Labels
[Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block [Feature] Navigation Component A navigational waterfall component for hierarchy of items. General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended

Comments

@draganescu
Copy link
Contributor

draganescu commented Mar 13, 2023

Description

In #48723 a page list which is a child of a navigation block immediately prompts the user to be converted to a list of navigation links if the user tries to select a page list item in the list view or the navigation block inspector.

However, right after clicking there is a half of an exit animation still ocuring below the modal that appears. This is because the animation is configured via a list of blocks that should animate, and that's about it! Sad.

useless-animation.mp4

What to do

We need to either upgrade that block animation configuration to an actual API where the animations can be started and canceled programatically, or, even better, move it to a better stage where we implement the Navigator component, and deprecate the "block animation API" altogether because now the Navigator component has been improved as part of the work on the browse mode sidebar.

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@draganescu draganescu added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. [Block] Navigation Affects the Navigation Block [Feature] Navigation Component A navigational waterfall component for hierarchy of items. [Block] Page List Affects the Page List Block labels Mar 13, 2023
@talldan
Copy link
Contributor

talldan commented Mar 14, 2023

It'd be good to have a video of the animation in question.

@draganescu
Copy link
Contributor Author

Added recording @talldan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block [Feature] Navigation Component A navigational waterfall component for hierarchy of items. General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants