Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore prompt to convert page link on drop instead of drag #49035

Open
draganescu opened this issue Mar 13, 2023 · 0 comments
Open

Explore prompt to convert page link on drop instead of drag #49035

draganescu opened this issue Mar 13, 2023 · 0 comments
Labels
[Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block [Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Enhancement A suggestion for improvement.

Comments

@draganescu
Copy link
Contributor

What problem does this address?

Currently, after #48723, when a page list is a child of a navigation block, dragging a page list child in the navigation block's inspector prompts the user immediately to convert the page list block to a list of navigation link blocks.

This creates an unexpected modal before the user effects their intent and so the user is in a state where they have a chip attached to their pointer on top of the modal. This is weird and it creates uncertainty on results of next step.

What is your proposed solution?

Let's explore triggering the modal when the page list item is dropped. There are two advantages of this:

  1. We show the modal once the user has their focus on "what's next" and we don't interrupt their flow
  2. We could know the drop target and, indifferent of what they choose following the prompt, we commit their action (basically the reordering).
@draganescu draganescu added [Type] Enhancement A suggestion for improvement. [Feature] Drag and Drop Drag and drop functionality when working with blocks [Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block labels Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block [Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

1 participant