Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move page list item offcanvas navigation lock icons to the page list #47268

Closed
1 task
richtabor opened this issue Jan 19, 2023 · 8 comments
Closed
1 task

Move page list item offcanvas navigation lock icons to the page list #47268

richtabor opened this issue Jan 19, 2023 · 8 comments
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

What problem does this address?

Currently each page list item shows a lock icon, to indicate the item cannot be manipulated within the navigation list view. Instead we can reduce the cognitive load here by moving the lock icons to the parent page list block.

What is your proposed solution?

  • In the offcanvas view, move the individual lock icons from the page list item blocks to the page list block

Visual

Note that the left-most block iconography in this visual is derived from #47267.

CleanShot 2023-01-19 at 11 14 22@2x

@richtabor richtabor added the [Block] Navigation Affects the Navigation Block label Jan 19, 2023
@richtabor richtabor changed the title Move page list item offcanvas navigation lock icons to the parent page list block Move page list item offcanvas navigation lock icons to the page list Jan 19, 2023
@scruffian
Copy link
Contributor

One concern I have with this approach is that it suggest that the block itself is locked which is not true - only the content is. Is there a way to make that distinction visually, or is that overkill?

@richtabor
Copy link
Member Author

Is there a way to make that distinction visually, or is that overkill?

I think overkill. But perhaps this could become obsolete if we "unlock" it per se #48034

@ndiego
Copy link
Member

ndiego commented Feb 22, 2023

Just checking in. Are we still aiming to get this resolved for 6.2?

@scruffian
Copy link
Contributor

I don't think so, no.

@ndiego
Copy link
Member

ndiego commented Feb 22, 2023

Thanks @scruffian, I will punt to 6.3.

@ndiego ndiego moved this from 📥 Todo to 🦵 Punted to 6.3 in WordPress 6.2 Editor Tasks Feb 22, 2023
@ndiego ndiego moved this to ❓ Triage in WordPress 6.3.x Editor Tasks May 23, 2023
@ndiego
Copy link
Member

ndiego commented Jun 12, 2023

Hey @scruffian @richtabor, this issue was ported over to the 6.3 Project Board after being punted from 6.2. It doesn't look like any further progress has been made. Given that 6.3 Beta 1 is two weeks away, any objections to me removing it from the 6.3 board?

@ndiego ndiego added the [Type] Enhancement A suggestion for improvement. label Jun 12, 2023
@scruffian
Copy link
Contributor

@ndiego fine with me

@richtabor
Copy link
Member Author

We can just close this, as the lock icons aren't there at all anymore :)

CleanShot 2023-06-14 at 16 26 31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants