-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to remove Border Radius on Button #4544
Comments
This looks like theme territory for me, can't you add this styling to your theme instead? |
If user have no idea about theme styling then this block is not usable for him. I think default border radius is not so good option. Let's think over it what will be the better solution for it. |
I'm just helping out a designer to get their themes gutenberg-ready, so here is what she says: Markup and classes used by this button are gutenberg-specifc, so no "old" theme will see it's button styling applied. Styling a button is not trivial. The currently used layout with full-color background and rounded corners will break the visual appearance of many themes, escpecially the 'minimalistic' ones. Her suggestion with 3 options: a) use transparent background with border (color same as text, default) vs use full color background The default color should be the themes link color. |
I would close this for now as up the theme. |
How can that field be removed in the Editor? I know theme can override CSS style, but how can one disable the field so that an editor cannot set the radius in the first place? |
Agreed, a filter to disable these little editor settings like the border radius slider, background color pallet on buttons and many others would be highly beneficial. |
Nearly all the sites I build have strict style guides with, among other things, specific button styles. Usually they consist of only a few styles, like a square cornered one and a semi/fully rounded one. Letting the client set a custom border radius on any button will mess with our design. I could simply add a At the absolute minimum, I should be able to target and The only other solution I can think of right now is to literally roll my own copy of the Button (and Buttons) blocks without these panels in the edit render. @karmatosed I agree this should be up to the theme to remove but there needs to be a way to actually remove the interface and not just the effect. |
Can you try using |
Oh sorry, I just realized how old this thread is. The border radius is no longer a block style but a setting on the button block, as a slider from 0 to 50px. I guess this should be opened up as a new issue. |
Doug made an issue here, if any of you are looking for it. #19796 |
Enhancement Overview
I am editing the content and want to add the button without border radius but there is no option to remove border radius so there should be option to remove border radius.
Steps to Reproduce (for bugs)
Expected Behavior
There should be option to remove border radius.
Screenshots / Video
The text was updated successfully, but these errors were encountered: