Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline button: inherits background-image if gradient is applied #45233

Closed
mikachan opened this issue Oct 23, 2022 · 0 comments · Fixed by #45234
Closed

Outline button: inherits background-image if gradient is applied #45233

mikachan opened this issue Oct 23, 2022 · 0 comments · Fixed by #45234
Assignees
Labels
[Block] Buttons Affects the Buttons Block [Type] Bug An existing feature does not function as intended

Comments

@mikachan
Copy link
Member

Description

The 'outline' style of the button block incorrectly inherits the background-image property if a button.color.gradient is used in theme.json. I believe this should be set to none, in the same way as the 'outline' style sets the background-color to transparent, in order for this button style to be an outline button.

See the Pilgrimage TT3 style variation for an example of this:

image

Step-by-step reproduction instructions

  1. Enable TT3 and pick the Pilgrimage style variation
  2. Insert a button block with the 'outline' style
  3. See that the background property is inherited from the default button settings:

image

Screenshots, screen recording, code snippet

No response

Environment info

  • WP 6.1 RC2, GB 14.4.0

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@mikachan mikachan added [Type] Bug An existing feature does not function as intended [Block] Buttons Affects the Buttons Block labels Oct 23, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 23, 2022
@cbravobernal cbravobernal moved this from Triage to Done in WordPress 6.1 Editor Tasks Oct 24, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants