Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heading level should not be identified as related to "size" #4407

Closed
afercia opened this issue Jan 11, 2018 · 2 comments
Closed

Heading level should not be identified as related to "size" #4407

afercia opened this issue Jan 11, 2018 · 2 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time

Comments

@afercia
Copy link
Contributor

afercia commented Jan 11, 2018

For no reason, ever, the interface should suggest users the heading levels are related to the font "size". Headings have been abused for years because of lack of awareness and because many users used them just for their size.

Currently, in the sidebar, the levels have a "Size" label:

screen shot 2018-01-11 at 15 19 20

This should be changed to "level".
@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jan 11, 2018
@ellatrix ellatrix added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Jan 12, 2018
@rileybrook rileybrook mentioned this issue Jan 12, 2018
Merged
3 tasks
@aduth
Copy link
Member

aduth commented Jan 12, 2018

Closed by #4440

(Aside: @rileybrook , as an FYI, you can use keywords to automatically close issues by pull requests)

@aduth aduth closed this as completed Jan 12, 2018
@rileybrook
Copy link

rileybrook commented Jan 12, 2018 •
edited
Loading

Thank you @aduth - will apply correct keywords moving forward 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@afercia @aduth @ellatrix @rileybrook