File block with a pdf upload becomes invalid in the editor when changing languages

[talldan]

Description

Discovered in #42745 (comment).

The file block uses __ in its save function. It's a static block so the internationalized output causes the block to be non-deterministic, resulting in validation errors.

Typically save output for static blocks can't be internationalized.

This could be a tricky one to solve, as removing the use of __ could cause a lot of blocks added in the non-default language to become invalidated. Maybe a deprecation is possible though.

Step-by-step reproduction instructions

To repro (in the post editor):

1. Upload a pdf to a file block
2. Publish the post
3. Change to a different language
4. Reload the post in the editor
5. Observe that the file block now has a validation error

I would recommend reproducing without the Gutenberg plugin active, as a lot of the translations are missing (at least for the dev version).

Screenshots, screen recording, code snippet

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[petitphp]

I successfully reproduced the issue with a WordPress 6.0.1 install without the Gutenberg plugin.

• I've inserted a file block in a new article, uploaded a pdf and save it,
• I went to the user profile and changed the site locale from EN to FR,
• I've reopened the article and observed that the file block encountered a validation error.

This error displayed in the web console :

Block validation: Block validation failed for `core/file`

Content generated by `save` function:

<div class="wp-block-file"><object [...] aria-label="Contenu embarqué lorem_ipsum."></object>[...]</div>

Content retrieved from post body:

<div class="wp-block-file"><object [...] aria-label="Embed of lorem_ipsum."></object>[...]</div>

The validation error did come from the localized aria-label of the object element changing with the locale.

[github-actions]

Hi,
This issue has gone 180 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

[talldan]

This one was fixed by #43050