Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more specific naming in edit site export files #38194

Closed
jeremyfelt opened this issue Jan 25, 2022 · 1 comment
Closed

Use more specific naming in edit site export files #38194

jeremyfelt opened this issue Jan 25, 2022 · 1 comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Enhancement A suggestion for improvement.

Comments

@jeremyfelt
Copy link
Member

What problem does this address?

  • The filename used when exporting templates from the site editor is edit-site-export.zip.
  • The directory name used when extracting an edit-site-export.zip file is theme.

My current (still figuring this out) workflow is to start with a blank canvas in the site editor, add blocks, and then export the templates so that I can use the markup in the theme for activation elsewhere.

Repeating this process causes my downloads directory to fill up with edit-site-export.zip, edit-site-export(1).zip, edit-site-export(2).zip, etc...

When I extract those zip files, they become theme/, theme 2/, theme 3/, etc...

When working on multiple sites/themes at once, this quickly becomes confusing OR I need to manually rename each one when downloading.

What is your proposed solution?

  • The default filename should be more specific. Something like edit-site-{domain}-{yyyymmdd}.zip
  • The default compressed directory name should be more specific. Something like edit-site-{theme-name}/

It would also be ideal to have a filter for these filenames.

@Mamaduka Mamaduka added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement. labels Jan 25, 2022
@carolinan carolinan added the [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. label Jan 25, 2022
@scruffian
Copy link
Contributor

The export now has the name of the theme. I think we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants