Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: return SlotFill for W button #36366

Closed
vindl opened this issue Nov 9, 2021 · 0 comments · Fixed by #36369
Closed

Site Editor: return SlotFill for W button #36366

vindl opened this issue Nov 9, 2021 · 0 comments · Fixed by #36369
Assignees
Labels
[Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@vindl
Copy link
Member

vindl commented Nov 9, 2021

Description

Initially we had a SlotFill for W button that allowed 3rd party apps to override this button in a maintainable way. Most notably this was useful for changing the back URL and site icon.

After the introduction, refactor, and removal of Browsing Sidebar this slot is no longer present, so the previous functionality has regressed.

This should've been included in #36194.

Here is how it previously looked

<MainDashboardButton.Slot>
<NavigationBackButton
.

Ideally we would use this same Slot/Fill here - similar to how the post editor uses its equivalent.

Step-by-step reproduction instructions

N/A

Screenshots, screen recording, code snippet

No response

Environment info

Gutenberg 11.9

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@vindl vindl added [Type] Regression Related to a regression in the latest release [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended labels Nov 9, 2021
@Mamaduka Mamaduka self-assigned this Nov 10, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 10, 2021
@Mamaduka Mamaduka removed their assignment Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants