Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a visually hidden label to the search block #34989

Closed
carolinan opened this issue Sep 21, 2021 · 0 comments · Fixed by #35034
Closed

Add a visually hidden label to the search block #34989

carolinan opened this issue Sep 21, 2021 · 0 comments · Fixed by #35034
Assignees
@carolinan
Labels
[Block] Search Affects the Search Block - used to display a search field [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@carolinan
Copy link
Contributor

What problem does this address?

The search block has an option to toggle the form label on and off.
Turning it off removes the label completely. This results in a lack of context for non sighted users.

Read more:
#24666 (comment)
https://dequeuniversity.com/rules/axe/3.3/label

What is your proposed solution?

Instead of removing it completely, a visually hidden label should be present.
The visually hidden form label should work both with a custom text and the default label.
@carolinan carolinan added [Type] Bug An existing feature does not function as intended [a11y] Labelling [Block] Search Affects the Search Block - used to display a search field labels Sep 21, 2021
@carolinan carolinan self-assigned this Sep 22, 2021
@carolinan carolinan mentioned this issue Sep 22, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 22, 2021
@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Labelling labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carolinan carolinan

Labels
[Block] Search Affects the Search Block - used to display a search field [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Block: Search] Add a visually hidden label WordPress/gutenberg
2 participants
@carolinan @priethor