Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomSelectControl: downshift warning in console about uncontrolled "selectedItem" prop #34524

Closed
andrewserong opened this issue Sep 3, 2021 · 0 comments · Fixed by #34721
Closed
Assignees
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@andrewserong
Copy link
Contributor

Description

Following on from #34520 this issue is to track a warning from downshift about selectedItem switching between being a controlled vs uncontrolled prop. It occurs in the global styles for the Site Title block when switching between different types of Appearance.

I previously made an attempt to fix it as part of #34520, but to get a shorter-term fix for in, I've created this issue to track the follow-up for this warning. See discussion at: #34520 (comment)

Step-by-step reproduction instructions

With #34520 applied (so that you're able to select

  1. Activate the TT1-Blocks theme (which sets a font weight but not a font style attribute for the Site Title block)
  2. Open up the site editor and the global styles panel
  3. Open up your browser console
  4. From the global styles panel, select the Site Title block, and adjust the appearance between the default value and any of the real values. After switching back and forward a couple of times, you should see the error message in the screenshot

Screenshots, screen recording, code snippet

image

Environment info

  • TT1-blocks theme

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@andrewserong andrewserong added [Type] Bug An existing feature does not function as intended [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Sep 3, 2021
@andrewserong andrewserong self-assigned this Sep 3, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant